Add AuthorDetails Concern

#TODO Tests

Author: seuros

app/controllers/comments_controller.rb

@@ -21,10 +21,6 @@ def create
       @comment = @protip.comments.build(create_comment_params)
 
       @comment.user = current_user
-      @comment.user_name = current_user.name
-      @comment.user_email = current_user.email
-      @comment.user_agent = request.user_agent
-      @comment.user_ip = request.remote_ip
       @comment.request_format = request.format.to_s
 
       if @comment.save

app/models/comment.rb

@@ -17,6 +17,7 @@
 
 class Comment < ActiveRecord::Base
   include ActsAsCommentable::Comment
+  include AuthorDetails
   include SpamFilter
 
   belongs_to :commentable, polymorphic: true

app/models/concerns/author_details.rb

@@ -0,0 +1,13 @@
+module AuthorDetails
+  extend ActiveSupport::Concern
+
+  included do
+    before_save do
+      self.user_name = user.name
+      self.user_email = user.email
+      self.user_agent = user.last_ua
+      self.user_ip = user.last_ip
+    end
+  end
+
+end

app/models/concerns/spam_filter.rb

@@ -2,7 +2,6 @@ module SpamFilter
   extend ActiveSupport::Concern
 
   included do
-    after_save :analyze_spam
     has_one :spam_report, as: :spammable
     include Rakismet::Model
 
@@ -13,9 +12,9 @@ module SpamFilter
                    user_ip: :remote_ip,
                    user_agent: :user_agent
 
-    def analyze_spam
+     after_save do
       AnalyzeSpamJob.perform_async({ id: id, klass: self.class.name })
-    end
+     end
 
   end
 end

app/models/protip.rb

@@ -43,6 +43,7 @@ class Protip < ActiveRecord::Base
   acts_as_commentable
 
   include ProtipMapping
+  include AuthorDetails
   include SpamFilter
 
   paginates_per(PAGESIZE = 18)