Finer Controls for S3 Events Notifications

[ivan-pinatti]

what

Introduce a new variable to have a fine-grained control about the type of S3 Events to trigger the Lambda Notification.

Requires change in underlying Terraform module to be applied first; cloudposse/terraform-aws-datadog-lambda-forwarder#105

why

Default should capture all the Create and Removal events (safer and more compreensive)
AND the variable would provide flexibility to include / remove as needed by users.

references

• Finer Controls for S3 Events Notifications cloudposse/terraform-aws-datadog-lambda-forwarder#105

Summary by CodeRabbit

• New Features
  • Added support to configure which S3 events trigger Datadog Lambda Forwarder notifications, enabling fine-grained control over event handling.
  • Introduced a user-configurable setting to pass a list of S3 events into the module, with sensible defaults covering object creation and removal.

[coderabbitai]

Walkthrough

Introduces a new Terraform variable s3_notification_events and wires it into the datadog_lambda_forwarder module in src/main.tf, passing var.s3_notification_events to the module.

Changes

Cohort / File(s)	Change Summary
Terraform input propagation src/variables.tf, src/main.tf	Added variable s3_notification_events (list(string) with default values) and passed it into module "datadog_lambda_forwarder" via s3_notification_events = var.s3_notification_events.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I twitch my whiskers, configs align,
New S3 events hop into line.
A forwarder listens—thump, thump—aware,
Buckets whisper changes in the air.
Tiny paws commit, terraform applies,
Logs leap forward—carrots for the eyes! 🥕🐇

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title clearly summarizes the main change by indicating the addition of finer-grained control over S3 event notifications, which aligns exactly with the introduced variable and module update. It's concise, specific to the change, and avoids vague or extraneous phrasing.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f1338b7 and 7e6a62d.

📒 Files selected for processing (2)

• src/main.tf (1 hunks)
• src/variables.tf (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

src/{main,variables,outputs,providers,versions,context}.tf

📄 CodeRabbit inference engine (AGENTS.md)

Keep the Terraform component files in src/: main.tf, variables.tf, outputs.tf, providers.tf, versions.tf, context.tf (source of truth)

Files:

• src/variables.tf
• src/main.tf

src/**/*.tf

📄 CodeRabbit inference engine (AGENTS.md)

src/**/*.tf: Use 2-space indentation for Terraform files
In Terraform, use lower_snake_case for variables and locals
Keep resource and data source names descriptive and aligned with Cloud Posse null-label patterns
Run terraform fmt and commit only formatted Terraform code
Adhere to TFLint rules defined in .tflint.hcl; do not commit lint violations

Files:

• src/variables.tf
• src/main.tf

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Summary

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[goruha]

@ivan-pinatti could you pls update the module version to https://github.com/cloudposse/terraform-aws-datadog-lambda-forwarder/releases/tag/v1.10.0