test(integration): fix session_exists tests to use multiple tabs

- Update tests to open sign-in in multiple tabs before signing in
- This properly tests the session_exists error scenario where the sign-in component is already mounted
- Sign in on one tab, then attempt to sign in on the other tab
- Prevents component from redirecting on mount before API call is made

Author: brkalow

integration/tests/oauth-flows.test.ts

@@ -264,8 +264,16 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withLegalConsent] })(
     }) => {
       const u = createTestUtils({ app, page, context, browser });
 
-      // Sign in on the first tab via OAuth
+      // Open sign-in page in both tabs before signing in
       await u.po.signIn.goTo();
+
+      let secondTabUtils: any;
+      await u.tabs.runInNewTab(async u2 => {
+        secondTabUtils = u2;
+        await u2.po.signIn.goTo();
+      });
+
+      // Sign in via OAuth on the first tab
       await u.page.getByRole('button', { name: 'E2E OAuth Provider' }).click();
       await u.page.getByText('Sign in to oauth-provider').waitFor();
       await u.po.signIn.setIdentifier(fakeUser.email);
@@ -274,18 +282,11 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withLegalConsent] })(
       await u.page.getByText('SignedIn').waitFor();
       await u.po.expect.toBeSignedIn();
 
-      // Open a new tab and attempt to sign in again via OAuth with the same user
-      await u.tabs.runInNewTab(async u2 => {
-        await u2.po.signIn.goTo();
-        await u2.page.getByRole('button', { name: 'E2E OAuth Provider' }).click();
-        await u2.page.getByText('Sign in to oauth-provider').waitFor();
-        await u2.po.signIn.setIdentifier(fakeUser.email);
-        await u2.po.signIn.continue();
-        await u2.po.signIn.enterTestOtpCode();
-
-        // Should redirect and remain signed in instead of showing an error
-        await u2.po.expect.toBeSignedIn();
-      });
+      // Attempt to sign in via OAuth on the second tab (which already has sign-in mounted)
+      await secondTabUtils.page.getByRole('button', { name: 'E2E OAuth Provider' }).click();
+
+      // Should redirect and be signed in without error
+      await secondTabUtils.po.expect.toBeSignedIn();
     });
   },
 );

integration/tests/sign-in-flow.test.ts

@@ -158,46 +158,59 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withEmailCodes] })('sign in f
   }) => {
     const u = createTestUtils({ app, page, context, browser });
 
-    // Sign in on the first tab
+    // Open sign-in page in both tabs before signing in
     await u.po.signIn.goTo();
+
+    let secondTabUtils: any;
+    await u.tabs.runInNewTab(async u2 => {
+      secondTabUtils = u2;
+      await u2.po.signIn.goTo();
+    });
+
+    // Sign in on the first tab
     await u.po.signIn.setIdentifier(fakeUser.email);
     await u.po.signIn.continue();
     await u.po.signIn.setPassword(fakeUser.password);
     await u.po.signIn.continue();
     await u.po.expect.toBeSignedIn();
 
-    // Open a new tab and attempt to sign in again with the same user
-    await u.tabs.runInNewTab(async u2 => {
-      await u2.po.signIn.goTo();
-      await u2.po.signIn.setIdentifier(fakeUser.email);
-      await u2.po.signIn.continue();
-      await u2.po.signIn.setPassword(fakeUser.password);
-      await u2.po.signIn.continue();
+    // Attempt to sign in on the second tab (which already has sign-in mounted)
+    await secondTabUtils.po.signIn.setIdentifier(fakeUser.email);
+    await secondTabUtils.po.signIn.continue();
+    await secondTabUtils.po.signIn.setPassword(fakeUser.password);
+    await secondTabUtils.po.signIn.continue();
 
-      // Should redirect and be signed in without error
-      await u2.po.expect.toBeSignedIn();
-    });
+    // Should redirect and be signed in without error
+    await secondTabUtils.po.expect.toBeSignedIn();
   });
 
-  test('redirects when attempting to sign in again with instant password in another tab', async ({
+  test('redirects when attempting to sign in with instant password and existing session in another tab', async ({
     page,
     context,
     browser,
   }) => {
     const u = createTestUtils({ app, page, context, browser });
 
-    // Sign in on the first tab
+    // Open sign-in page in both tabs before signing in
     await u.po.signIn.goTo();
-    await u.po.signIn.signInWithEmailAndInstantPassword({ email: fakeUser.email, password: fakeUser.password });
-    await u.po.expect.toBeSignedIn();
 
-    // Open a new tab and attempt to sign in again with instant password
+    let secondTabUtils: any;
     await u.tabs.runInNewTab(async u2 => {
+      secondTabUtils = u2;
       await u2.po.signIn.goTo();
-      await u2.po.signIn.signInWithEmailAndInstantPassword({ email: fakeUser.email, password: fakeUser.password });
+    });
 
-      // Should redirect and remain signed in without error
-      await u2.po.expect.toBeSignedIn();
+    // Sign in with instant password on the first tab
+    await u.po.signIn.signInWithEmailAndInstantPassword({ email: fakeUser.email, password: fakeUser.password });
+    await u.po.expect.toBeSignedIn();
+
+    // Attempt to sign in with instant password on the second tab
+    await secondTabUtils.po.signIn.signInWithEmailAndInstantPassword({
+      email: fakeUser.email,
+      password: fakeUser.password,
     });
+
+    // Should redirect and be signed in without error
+    await secondTabUtils.po.expect.toBeSignedIn();
   });
 });