tasklog/log.go: simplify consume() method

The *Logger.consume() method in the "tasklog" package was first
introduced in commit e90d54d of
PR git-lfs#2329, and since that time has included logic to manage an
internal "pending" list of tasks; however, that logic is never
exercised because tasks are only appended to the "pending" array
when the "next" variable is non-nil, but that variable is
initialized as nil and can only be set to another value if the
"pending" array is non-empty.

As a result, we can remove both variables and the related logic
and simplify the consume() method as a result.

Author: chrisd8088

tasklog/log.go

@@ -189,50 +189,19 @@ func (l *Logger) consume() {
 
 	defer close(l.tasks)
 
-	pending := make([]Task, 0)
-
 	for {
-		// If there is a pending task, "peek" it off of the set of
-		// pending tasks.
-		var next Task
-		if len(pending) > 0 {
-			next = pending[0]
+		// Wait for either a) l.queue to close, or b) a new task
+		// to be submitted.
+		task, ok := <-l.queue
+		if !ok {
+			// If the queue is closed, no more new tasks may
+			// be added.
+			return
 		}
 
-		if next == nil {
-			// If there was no pending task, wait for either a)
-			// l.queue to close, or b) a new task to be submitted.
-			task, ok := <-l.queue
-			if !ok {
-				// If the queue is closed, no more new tasks may
-				// be added.
-				return
-			}
-
-			// Otherwise, add a new task to the set of tasks to
-			// process immediately, since there is no current
-			// buffer.
-			l.tasks <- task
-		} else {
-			// If there is a pending task, wait for either a) a
-			// write to process the task to become non-blocking, or
-			// b) a new task to enter the queue.
-			select {
-			case task, ok := <-l.queue:
-				if !ok {
-					// If the queue is closed, no more tasks
-					// may be added.
-					return
-				}
-				// Otherwise, add the next task to the set of
-				// pending, active tasks.
-				pending = append(pending, task)
-			case l.tasks <- next:
-				// Or "pop" the peeked task off of the pending
-				// set.
-				pending = pending[1:]
-			}
-		}
+		// Otherwise, add a new task to the set of tasks to
+		// process immediately.
+		l.tasks <- task
 	}
 }