t: rename existing/missing/bad object push tests

Our t/t-pre-push.sh and t/t-push-failures-local.sh test scripts include
a number of tests which validate the behaviour of the "git lfs pre-push"
and "git push" commands when Git LFS objects are present, missing, or
corrupt.

While these tests are largely similar in their implementation, they
vary in a number of formatting and implementation details unrelated to
the specifics of the different conditions they simulate.  These
variations are artifacts of the evolution of our test suite over time;
for example, the tests in the t/t-push-failures-local.sh script were
refactored and collected from several earlier tests in commit
4d52e08 of PR git-lfs#3109, and the original
versions of the tests in the t/t-pre-push.sh script were added
incrementally in PRs git-lfs#447, git-lfs#2199, and git-lfs#2574.

In a subsequent commit in this PR we expect to update the Git LFS
client to remove some non-functional code which attempts to recreate
missing Git LFS objects during push operations.  In many cases this
change will cause the client to report missing objects in an earlier
stage of push operations than it does now.  We also expect to reword
the error message the client will output in such cases.

Before we make these changes, we first revise the related tests in our
test suite so they are as simple and similar as possible.  This will
ensure that when we update the Git LFS client we can clearly identify
the changes that we need to make in our tests to accommodate the
client's new behaviour.

In previous commits in this PR we have revised and reformatted these
tests to increase their consistency with each other.  One additional
adjustment we make now to further increase this consistency, and to
provide greater clarity as to each test's purpose, is to rename both
the tests and test repositories they create and clone.

Note that since these tests typically only create a single missing
or corrupt object, we now use the singular word "object" rather than
"objects" in the test and repository names.

Author: chrisd8088

t/t-pre-push.sh

@@ -241,11 +241,11 @@ begin_test "pre-push 307 redirects"
 )
 end_test
 
-begin_test "pre-push with existing file"
+begin_test "pre-push with existing object"
 (
   set -e
 
-  reponame="pre-push-existing-file"
+  reponame="pre-push-existing-object"
   setup_remote_repo "$reponame"
   clone_repo "$reponame" "$reponame"
 
@@ -270,11 +270,11 @@ begin_test "pre-push with existing file"
 )
 end_test
 
-begin_test "pre-push with existing pointer"
+begin_test "pre-push with existing object (untracked)"
 (
   set -e
 
-  reponame="pre-push-existing-pointer"
+  reponame="pre-push-existing-object-untracked"
   setup_remote_repo "$reponame"
   clone_repo "$reponame" "$reponame"
 
@@ -295,11 +295,11 @@ begin_test "pre-push with existing pointer"
 )
 end_test
 
-begin_test "pre-push with missing pointer not on server"
+begin_test "pre-push reject missing object"
 (
   set -e
 
-  reponame="pre-push-missing-pointer"
+  reponame="pre-push-reject-missing-object"
   setup_remote_repo "$reponame"
   clone_repo "$reponame" "$reponame"
 
@@ -326,13 +326,13 @@ begin_test "pre-push with missing pointer not on server"
 )
 end_test
 
-begin_test "pre-push with missing pointer which is on server"
+begin_test "pre-push allow missing object (found on server)"
 (
   # should permit push if files missing locally but are on server, shouldn't
   # require client to have every file (prune)
   set -e
 
-  reponame="pre-push-missing-but-on-server"
+  reponame="pre-push-allow-missing-object-found-on-server"
   setup_remote_repo "$reponame"
   clone_repo "$reponame" "$reponame"
 
@@ -367,11 +367,11 @@ begin_test "pre-push with missing pointer which is on server"
 )
 end_test
 
-begin_test "pre-push with missing and present pointers (lfs.allowincompletepush true)"
+begin_test "pre-push allow missing object (lfs.allowincompletepush true)"
 (
   set -e
 
-  reponame="pre-push-missing-and-present"
+  reponame="pre-push-allow-missing-object"
   setup_remote_repo "$reponame"
   clone_repo "$reponame" "$reponame"
 
@@ -414,11 +414,11 @@ begin_test "pre-push with missing and present pointers (lfs.allowincompletepush
 )
 end_test
 
-begin_test "pre-push reject missing pointers (lfs.allowincompletepush default)"
+begin_test "pre-push reject missing object (lfs.allowincompletepush default)"
 (
   set -e
 
-  reponame="pre-push-reject-missing-and-present"
+  reponame="pre-push-reject-missing-object-default"
   setup_remote_repo "$reponame"
   clone_repo "$reponame" "$reponame"
 

t/t-push-failures-local.sh

@@ -2,11 +2,11 @@
 
 . "$(dirname "$0")/testlib.sh"
 
-begin_test "push with missing objects (lfs.allowincompletepush true)"
+begin_test "push allow missing object (lfs.allowincompletepush true)"
 (
   set -e
 
-  reponame="push-with-missing-objects"
+  reponame="push-allow-missing-object"
   setup_remote_repo "$reponame"
   clone_repo "$reponame" "$reponame"
 
@@ -46,11 +46,11 @@ begin_test "push with missing objects (lfs.allowincompletepush true)"
 )
 end_test
 
-begin_test "push reject missing objects (lfs.allowincompletepush false)"
+begin_test "push reject missing object (lfs.allowincompletepush false)"
 (
   set -e
 
-  reponame="push-reject-missing-objects"
+  reponame="push-reject-missing-object"
   setup_remote_repo "$reponame"
   clone_repo "$reponame" "$reponame"
 
@@ -89,11 +89,11 @@ begin_test "push reject missing objects (lfs.allowincompletepush false)"
 )
 end_test
 
-begin_test "push reject missing objects (lfs.allowincompletepush default)"
+begin_test "push reject missing object (lfs.allowincompletepush default)"
 (
   set -e
 
-  reponame="push-missing-objects"
+  reponame="push-reject-missing-object-default"
   setup_remote_repo "$reponame"
   clone_repo "$reponame" "$reponame"
 
@@ -128,11 +128,11 @@ begin_test "push reject missing objects (lfs.allowincompletepush default)"
 )
 end_test
 
-begin_test "push reject corrupt objects (lfs.allowincompletepush default)"
+begin_test "push reject corrupt object (lfs.allowincompletepush default)"
 (
   set -e
 
-  reponame="push-corrupt-objects"
+  reponame="push-reject-corrupt-object"
   setup_remote_repo "$reponame"
   clone_repo "$reponame" "$reponame"