Merge pull request #6730 from christianbeeznest/GH-6134-4

Assignment: Resolve child-entity error on delete - refs #6134

Author: christianbeeznest

src/CoreBundle/State/CStudentPublicationDeleteProcessor.php

@@ -8,42 +8,48 @@
 
 use ApiPlatform\Metadata\Operation;
 use ApiPlatform\State\ProcessorInterface;
-use Chamilo\CoreBundle\Repository\TrackEDefaultRepository;
 use Chamilo\CourseBundle\Entity\CStudentPublication;
+use Chamilo\CoreBundle\Entity\ResourceNode;
 use Doctrine\ORM\EntityManagerInterface;
 
 /**
  * @implements ProcessorInterface<CStudentPublication, void>
  */
 final class CStudentPublicationDeleteProcessor implements ProcessorInterface
 {
-    public function __construct(
-        private readonly EntityManagerInterface $entityManager,
-        private readonly TrackEDefaultRepository $trackRepo,
-    ) {}
-
-    public function process(
-        $data,
-        Operation $operation,
-        array $uriVariables = [],
-        array $context = []
-    ): void {
+    public function __construct(private readonly EntityManagerInterface $em) {}
+
+    public function process($data, Operation $operation, array $uriVariables = [], array $context = []): void
+    {
         if (!$data instanceof CStudentPublication) {
             return;
         }
 
-        if ($data->hasResourceNode()) {
-            $this->trackRepo->registerResourceEvent(
-                $data->getResourceNode(),
-                'deletion'
-            );
-        }
+        $node = $data->hasResourceNode() ? $data->getResourceNode() : null;
 
-        foreach ($data->getChildren() as $child) {
-            $this->entityManager->remove($child);
-        }
+        $this->em->beginTransaction();
+        try {
+            try { $this->em->refresh($data); } catch (\Throwable) {}
+
+            $this->em->remove($data);
+            $this->em->flush();
 
-        $this->entityManager->remove($data);
-        $this->entityManager->flush();
+            if ($node instanceof ResourceNode) {
+                foreach ($node->getResourceLinks() as $link) {
+                    $this->em->remove($link);
+                }
+                $this->em->flush();
+
+                foreach ($node->getResourceFiles() as $file) {
+                    $this->em->remove($file);
+                }
+                $this->em->flush();
+            }
+
+            $this->em->commit();
+        } catch (\Throwable $e) {
+            $this->em->rollback();
+            throw $e;
+        }
     }
 }

src/CourseBundle/Entity/CStudentPublication.php

@@ -147,7 +147,7 @@ class CStudentPublication extends AbstractResource implements ResourceInterface,
     /**
      * @var Collection<int, CStudentPublication>
      */
-    #[ORM\OneToMany(mappedBy: 'publicationParent', targetEntity: self::class)]
+    #[ORM\OneToMany(mappedBy: 'publicationParent', targetEntity: self::class, cascade: ['remove'], orphanRemoval: true)]
     protected Collection $children;
 
     /**
@@ -168,7 +168,7 @@ class CStudentPublication extends AbstractResource implements ResourceInterface,
     protected User $user;
 
     #[Groups(['c_student_publication:write', 'student_publication:read'])]
-    #[ORM\OneToOne(mappedBy: 'publication', targetEntity: CStudentPublicationAssignment::class, cascade: ['persist'])]
+    #[ORM\OneToOne(mappedBy: 'publication', targetEntity: CStudentPublicationAssignment::class, cascade: ['persist', 'remove'])]
     #[Assert\Valid]
     protected ?CStudentPublicationAssignment $assignment = null;
 

src/CourseBundle/Entity/CStudentPublicationAssignment.php

@@ -50,7 +50,7 @@ class CStudentPublicationAssignment implements Stringable
     #[ORM\Column(name: 'enable_qualification', type: 'boolean', nullable: false)]
     protected bool $enableQualification;
 
-    #[ORM\OneToOne(inversedBy: 'assignment', targetEntity: CStudentPublication::class)]
+    #[ORM\OneToOne(inversedBy: 'assignment', targetEntity: CStudentPublication::class, cascade: ['persist'])]
     #[ORM\JoinColumn(name: 'publication_id', referencedColumnName: 'iid', onDelete: 'CASCADE')]
     protected CStudentPublication $publication;