Strip lib from xcframework and android library directories

Author: kraenhansen

packages/ferric-example/.gitignore

@@ -5,5 +5,5 @@ Cargo.lock
 /*.android.node/
 
 # Generated files
-/libferric_example.d.ts
-/libferric_example.js
+/ferric_example.d.ts
+/ferric_example.js

packages/ferric-example/package.json

@@ -1,8 +1,8 @@
 {
   "name": "ferric-example",
   "version": "0.1.0",
-  "main": "libferric_example.js",
-  "types": "libferric_example.d.ts",
+  "main": "ferric_example.js",
+  "types": "ferric_example.d.ts",
   "scripts": {
     "build": "ferric build --android --apple"
   },

packages/react-native-node-api-modules/src/node/path-utils.ts

@@ -313,7 +313,8 @@ export function findNodeApiModulePathsByDependency({
  */
 export function determineLibraryFilename(libraryPaths: string[]) {
   const libraryNames = libraryPaths.map((p) =>
-    path.basename(p, path.extname(p))
+    // Strip the "lib" prefix and any file extension
+    path.basename(p, path.extname(p)).replace(/^lib/, "")
   );
   const candidates = new Set<string>(libraryNames);
   assert(candidates.size === 1, "Expected all libraries to have the same name");

packages/react-native-node-api-modules/src/node/prebuilds/apple.ts

@@ -6,7 +6,8 @@ import cp from "node:child_process";
 
 import { spawn } from "bufout";
 
-import { AppleTriplet } from "react-native-node-api-modules";
+import { AppleTriplet } from "./triplets.js";
+import { determineLibraryFilename } from "../path-utils.js";
 
 type AppleArchitecture = "arm64" | "x86_64" | "arm64;x86_64";
 
@@ -122,15 +123,7 @@ export async function createXCframework({
  * Ensuring that all framework paths have the same base name.
  */
 export function determineXCFrameworkFilename(frameworkPaths: string[]) {
-  const frameworkNames = frameworkPaths.map((p) =>
-    path.basename(p, path.extname(p))
-  );
-  const candidates = new Set<string>(frameworkNames);
-  assert(
-    candidates.size === 1,
-    "Expected all frameworks to have the same name"
-  );
-  const [name] = candidates;
+  const name = determineLibraryFilename(frameworkPaths);
   return `${name}.xcframework`;
 }