Skip to content

Commit 86cff81

Browse files
committed
TMP - LOT and stripping comments
1 parent 584dd92 commit 86cff81

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

packages/react-native-node-api-modules/android/CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@ cmake_minimum_required(VERSION 3.13)
22

33
project(react-native-node-api-modules)
44
set(CMAKE_CXX_STANDARD 20)
5+
# We need to disable IPO / LTO to avoid the "weak-node-api" library being optimized out of the Node-API modules.
6+
# set(CMAKE_INTERPROCEDURAL_OPTIMIZATION OFF)
57

68
find_package(ReactAndroid REQUIRED CONFIG)
79
find_package(hermes-engine REQUIRED CONFIG)

packages/react-native-node-api-modules/android/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ android {
120120

121121
packagingOptions {
122122
// TODO: I don't think this works - I needed to add this in the react-native package too.
123-
doNotStrip "**/libhermes.so"
123+
// doNotStrip "**/*.so"
124124
}
125125

126126
}

0 commit comments

Comments
 (0)