Skip to content

fix: separate example app from native library files #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2020
Merged

fix: separate example app from native library files #68

merged 1 commit into from
Sep 30, 2020

Conversation

@krizzu
Copy link
Collaborator

@krizzu krizzu commented Jul 16, 2020

Summary

Fixes #65

Separated Example app files from native library files. Conditional android package linking if project type is js.

Checklist

  • I have tested this

@krizzu krizzu requested a review from satya164 July 16, 2020 08:01
@ubmit ubmit mentioned this pull request Sep 3, 2020
Closed
@satya164 satya164 changed the title fix: Separate example app from native library files fix: separate example app from native library files Sep 30, 2020
@satya164 satya164 merged commit a4d2ba0 into callstack:master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@satya164 satya164 satya164 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Android build fails

2 participants

@krizzu @satya164