Skip to content

Conversation

@troZee
Copy link
Contributor

@troZee troZee commented Sep 16, 2021

Summary

Recent react-native dependencies are published to Maven Central only.

Test plan

Check if mavenCentral is above jcenter in repo structure

More context here: react-native-camera/react-native-camera#2490

@troZee troZee requested review from krizzu and satya164 September 16, 2021 13:05
Copy link
Member

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to keep jcenter?

@satya164 satya164 merged commit ecea932 into main Sep 27, 2021
@satya164 satya164 deleted the fix/add-maven-central branch September 27, 2021 23:24
@troZee
Copy link
Contributor Author

troZee commented Sep 29, 2021

Do we need to keep jcenter?

I think, we can completely remove it in the future, since it has been removed in RN 65: https://react-native-community.github.io/upgrade-helper/?from=0.64.2&to=0.65.1 . For now, we can keep it as it is.

okwasniewski pushed a commit that referenced this pull request Nov 4, 2022
### Summary

Recent react-native dependencies are published to Maven Central only.

### Test plan

Check if `mavenCentral` is above `jcenter` in repo structure 

More context here: react-native-camera/react-native-camera#2490

Co-authored-by: Piotr Trocki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants