fix: fallback bob version #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krizzu
approved these changes
Mar 11, 2021
Collaborator
krizzu
left a comment
krizzu
left a comment
There was a problem hiding this comment.
Nicely 👍 This will make sure that we always have a fallback version, even if fetching version from npm takes longer than one sec
satya164
reviewed
Mar 11, 2021
okwasniewski
pushed a commit
that referenced
this pull request
Nov 4, 2022
Co-authored-by: Piotr Trocki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #145
The fallback version was incorrect. This PR fixes it.
Test plan
Like always :D