Gp 155/random field comparator/completed

[Stanislav-Zabramnyi]

No description provided.

[tboychuk]

Please take a look at my comments. Thanks

[tboychuk]

It makes sense to do this.targetType = Objects.requireNonNull(targetType); or even
this.targetType = requireNonNull(targetType);

[tboychuk]

I'd move comparator into a local variable to make this line cleaner.

[tboychuk]

You user Comparable as raw type (without specifying a generic type), while you can actually provide a type argument and use it property. Both field values have the same type, so you need to create a helper method for compiler to catch that type.

@Override
    public int compare(T o1, T o2) {
        Objects.requireNonNull(o1);
        Objects.requireNonNull(o2);
        return compareFieldValues(o1, o2);
    }

    @SneakyThrows
    @SuppressWarnings("unchecked")
    private <U extends Comparable<? super U>> int compareFieldValues(T o1, T o2) {
        field.setAccessible(true);
        var value1 = (U) field.get(o1);
        var value2 = (U) field.get(o2);
        Comparator<U> comparator = Comparator.nullsLast(Comparator.naturalOrder());
        return comparator.compare(value1, value2);
    }

What I like about helper method is that you can put @SneakyThrows and well as @SuppressWarnings there, which makes method compare clean and simple. 🤷🏻‍♂️