service/sqs: Fix sqs batch send panic on failure (#239)

Fixes panic in verifySendMessageBatch if not all messages failed to send.

Author: ccbrown

service/sqs/checksums.go

@@ -50,10 +50,10 @@ func verifySendMessageBatch(r *request.Request) {
 
 		in := r.Params.(*SendMessageBatchInput)
 		for _, entry := range in.Entries {
-			e := entries[*entry.Id]
-			err := checksumsMatch(entry.MessageBody, e.MD5OfMessageBody)
-			if err != nil {
-				ids = append(ids, *e.MessageId)
+			if e, ok := entries[*entry.Id]; ok {
+				if err := checksumsMatch(entry.MessageBody, e.MD5OfMessageBody); err != nil {
+					ids = append(ids, *e.MessageId)
+				}
 			}
 		}
 		if len(ids) > 0 {

service/sqs/checksums_test.go

@@ -212,6 +212,33 @@ func TestSendMessageBatchChecksum(t *testing.T) {
 	}
 }
 
+func TestSendMessageBatchChecksumFailed(t *testing.T) {
+	req := svc.SendMessageBatchRequest(&sqs.SendMessageBatchInput{
+		Entries: []sqs.SendMessageBatchRequestEntry{
+			{Id: aws.String("1"), MessageBody: aws.String("test")},
+			{Id: aws.String("2"), MessageBody: aws.String("test")},
+			{Id: aws.String("3"), MessageBody: aws.String("test")},
+			{Id: aws.String("4"), MessageBody: aws.String("test")},
+		},
+	})
+	req.Handlers.Send.PushBack(func(r *request.Request) {
+		body := ioutil.NopCloser(bytes.NewReader([]byte("")))
+		r.HTTPResponse = &http.Response{StatusCode: 200, Body: body}
+		r.Data = &sqs.SendMessageBatchOutput{
+			Failed: []sqs.BatchResultErrorEntry{
+				{Id: aws.String("1"), Code: aws.String("test"), Message: aws.String("test"), SenderFault: aws.Bool(false)},
+				{Id: aws.String("2"), Code: aws.String("test"), Message: aws.String("test"), SenderFault: aws.Bool(false)},
+				{Id: aws.String("3"), Code: aws.String("test"), Message: aws.String("test"), SenderFault: aws.Bool(false)},
+				{Id: aws.String("4"), Code: aws.String("test"), Message: aws.String("test"), SenderFault: aws.Bool(false)},
+			},
+		}
+	})
+	_, err := req.Send()
+	if err != nil {
+		t.Errorf("expect no error, got %v", err)
+	}
+}
+
 func TestSendMessageBatchChecksumInvalid(t *testing.T) {
 	req := svc.SendMessageBatchRequest(&sqs.SendMessageBatchInput{
 		Entries: []sqs.SendMessageBatchRequestEntry{