fix(codebuild): setting Cache.none() renders nothing in the template (#18194)

When implementing caching in CodeBuild,
we made the default cache `Cache.none()`,
and, for that reason, do not render anything in the template for that type of cache.
However, that does not work well with the CodeBuild API,
which interprets the lack of a property as the signal to leave it unchanged.
Which means it's not possible currently to disable caching on a Project once it has been enabled once.

Fix this by differentiating between the case of "no Cache has been provided",
and "the none() Cache has been provided".

Closes #18165

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Author: skinny85

packages/@aws-cdk/aws-codebuild/lib/cache.ts

@@ -37,7 +37,13 @@ export enum LocalCacheMode {
  */
 export abstract class Cache {
   public static none(): Cache {
-    return { _toCloudFormation: () => undefined, _bind: () => { return; } };
+    return {
+      _toCloudFormation(): CfnProject.ProjectCacheProperty | undefined {
+        return { type: 'NO_CACHE' };
+      },
+      _bind(): void {
+      },
+    };
   }
 
   /**

packages/@aws-cdk/aws-codebuild/test/codebuild.test.ts

@@ -155,6 +155,9 @@ describe('default properties', () => {
               'ComputeType': 'BUILD_GENERAL1_SMALL',
             },
             'EncryptionKey': 'alias/aws/s3',
+            'Cache': {
+              'Type': 'NO_CACHE',
+            },
           },
         },
       },
@@ -335,6 +338,9 @@ describe('default properties', () => {
               'Type': 'CODECOMMIT',
             },
             'EncryptionKey': 'alias/aws/s3',
+            'Cache': {
+              'Type': 'NO_CACHE',
+            },
           },
         },
       },
@@ -539,6 +545,9 @@ describe('default properties', () => {
               'Type': 'S3',
             },
             'EncryptionKey': 'alias/aws/s3',
+            'Cache': {
+              'Type': 'NO_CACHE',
+            },
           },
         },
       },

packages/@aws-cdk/aws-codebuild/test/integ.aws-deep-learning-container-build-image.expected.json

@@ -210,6 +210,9 @@
           "BuildSpec": "{\n  \"version\": \"0.2\",\n  \"phases\": {\n    \"build\": {\n      \"commands\": [\n        \"ls\"\n      ]\n    }\n  }\n}",
           "Type": "NO_SOURCE"
         },
+        "Cache": {
+          "Type": "NO_CACHE"
+        },
         "EncryptionKey": "alias/aws/s3"
       }
     }

packages/@aws-cdk/aws-codebuild/test/integ.defaults.lit.expected.json

@@ -147,6 +147,9 @@
           "BuildSpec": "{\n  \"version\": \"0.2\",\n  \"phases\": {\n    \"build\": {\n      \"commands\": [\n        \"echo \\\"Hello, CodeBuild!\\\"\"\n      ]\n    }\n  }\n}",
           "Type": "NO_SOURCE"
         },
+        "Cache": {
+          "Type": "NO_CACHE"
+        },
         "EncryptionKey": "alias/aws/s3"
       }
     }

packages/@aws-cdk/aws-codebuild/test/integ.docker-asset.lit.expected.json

@@ -164,6 +164,9 @@
           "BuildSpec": "{\n  \"version\": \"0.2\",\n  \"phases\": {\n    \"build\": {\n      \"commands\": [\n        \"ls\"\n      ]\n    }\n  }\n}",
           "Type": "NO_SOURCE"
         },
+        "Cache": {
+          "Type": "NO_CACHE"
+        },
         "EncryptionKey": "alias/aws/s3"
       }
     }

packages/@aws-cdk/aws-codebuild/test/integ.docker-registry.lit.expected.json

@@ -155,6 +155,9 @@
           "BuildSpec": "{\n  \"version\": \"0.2\",\n  \"phases\": {\n    \"build\": {\n      \"commands\": [\n        \"ls\"\n      ]\n    }\n  }\n}",
           "Type": "NO_SOURCE"
         },
+        "Cache": {
+          "Type": "NO_CACHE"
+        },
         "EncryptionKey": "alias/aws/s3"
       }
     }

packages/@aws-cdk/aws-codebuild/test/integ.ecr.lit.expected.json

@@ -185,6 +185,9 @@
           "BuildSpec": "{\n  \"version\": \"0.2\",\n  \"phases\": {\n    \"build\": {\n      \"commands\": [\n        \"ls\"\n      ]\n    }\n  }\n}",
           "Type": "NO_SOURCE"
         },
+        "Cache": {
+          "Type": "NO_CACHE"
+        },
         "EncryptionKey": "alias/aws/s3"
       }
     }

packages/@aws-cdk/aws-codebuild/test/integ.github-webhook-batch.expected.json

@@ -169,6 +169,9 @@
             ]
           }
         },
+        "Cache": {
+          "Type": "NO_CACHE"
+        },
         "EncryptionKey": "alias/aws/s3",
         "Triggers": {
           "BuildType": "BUILD_BATCH",

packages/@aws-cdk/aws-codebuild/test/integ.github.expected.json

@@ -114,6 +114,9 @@
           "ReportBuildStatus": false,
           "Type": "GITHUB"
         },
+        "Cache": {
+          "Type": "NO_CACHE"
+        },
         "EncryptionKey": "alias/aws/s3"
       }
     }

packages/@aws-cdk/aws-codebuild/test/integ.project-bucket.expected.json

@@ -158,6 +158,9 @@
           },
           "Type": "S3"
         },
+        "Cache": {
+          "Type": "NO_CACHE"
+        },
         "EncryptionKey": "alias/aws/s3"
       }
     }