Skip to content

fix(authenticator): Log auth exception #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2023
Merged

fix(authenticator): Log auth exception #39

merged 1 commit into from
May 23, 2023

Conversation

mattcreaser
Copy link
Member

Issue #, if available:

Description of changes:

  • If an AuthException happens for Authenticator log the actual exception for developer insight into the problem.

How did you test these changes?

  • Generated an exception and checked logs

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested review from a team as code owners May 23, 2023 13:13
@mattcreaser mattcreaser enabled auto-merge May 23, 2023 13:19
@mattcreaser mattcreaser added this pull request to the merge queue May 23, 2023
Merged via the queue into main with commit 3bda5e2 May 23, 2023
@mattcreaser mattcreaser deleted the mattcreaser/log-error branch May 23, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerjroach tylerjroach tylerjroach approved these changes

+1 more reviewer

@sdhuka sdhuka sdhuka approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattcreaser @tylerjroach @sdhuka