Skip to content

Commit 0af57df

Browse files
authored
Fix Windows login issue (#526)
Windows seems to have a very low limit for the length of command arguments when spawning, so our recent currency additions made it go over that limit. A quick fix for now is to exclude the `electrumServers` property as it's not used by marketmaker. A proper longer-term fix would be for marketmaker to let us dynamically enable currencies with this info instead of having to supply it on startup. Fixes #519 Fixes #525
1 parent c848feb commit 0af57df

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

app/marketmaker/index.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ const util = require('electron-util');
88
const getPort = require('get-port');
99
const logger = require('electron-timber');
1010
const makeDir = require('make-dir');
11+
const _ = require('lodash');
1112
const {supportedCurrencies} = require('./supported-currencies');
1213

1314
// `electron-builder` uses different names
@@ -73,7 +74,9 @@ class Marketmaker {
7374
gui: 'hyperdex',
7475
userhome: os.homedir(),
7576
rpcport: await getPort(),
76-
coins: supportedCurrencies,
77+
// We leave out `electrumServers` since it's not needed
78+
// and to prevent issues on Windows with too long arguments
79+
coins: supportedCurrencies.map(currency => _.omit(currency, ['electrumServers'])),
7780
};
7881

7982
this.port = options.rpcport;

0 commit comments

Comments
 (0)