Make sure we are always throwing an exception from Core (#841)

Nyholm · web-flow · commit 7e9488df2e97 · 2020-11-03T14:44:37.000+01:00
* Make sure we are always throwing an exception from Core

* Make sure we generate classes to throw correct exception

* ./generate --all

* Shorten name

* Do cover integrations

* Added changelog
diff --git a/src/Result/BatchGetItemOutput.php b/src/Result/BatchGetItemOutput.php
@@ -2,6 +2,7 @@
 
 namespace AsyncAws\DynamoDb\Result;
 
+use AsyncAws\Core\Exception\InvalidArgument;
 use AsyncAws\Core\Response;
 use AsyncAws\Core\Result;
 use AsyncAws\DynamoDb\DynamoDbClient;
@@ -50,10 +51,10 @@ public function getConsumedCapacity(bool $currentPageOnly = false): iterable
 
         $client = $this->awsClient;
         if (!$client instanceof DynamoDbClient) {
-            throw new \InvalidArgumentException('missing client injected in paginated result');
+            throw new InvalidArgument('missing client injected in paginated result');
         }
         if (!$this->input instanceof BatchGetItemInput) {
-            throw new \InvalidArgumentException('missing last request injected in paginated result');
+            throw new InvalidArgument('missing last request injected in paginated result');
         }
         $input = clone $this->input;
         $page = $this;
@@ -86,10 +87,10 @@ public function getIterator(): \Traversable
     {
         $client = $this->awsClient;
         if (!$client instanceof DynamoDbClient) {
-            throw new \InvalidArgumentException('missing client injected in paginated result');
+            throw new InvalidArgument('missing client injected in paginated result');
         }
         if (!$this->input instanceof BatchGetItemInput) {
-            throw new \InvalidArgumentException('missing last request injected in paginated result');
+            throw new InvalidArgument('missing last request injected in paginated result');
         }
         $input = clone $this->input;
         $page = $this;
diff --git a/src/Result/ListTablesOutput.php b/src/Result/ListTablesOutput.php
@@ -2,6 +2,7 @@
 
 namespace AsyncAws\DynamoDb\Result;
 
+use AsyncAws\Core\Exception\InvalidArgument;
 use AsyncAws\Core\Response;
 use AsyncAws\Core\Result;
 use AsyncAws\DynamoDb\DynamoDbClient;
@@ -33,10 +34,10 @@ public function getIterator(): \Traversable
     {
         $client = $this->awsClient;
         if (!$client instanceof DynamoDbClient) {
-            throw new \InvalidArgumentException('missing client injected in paginated result');
+            throw new InvalidArgument('missing client injected in paginated result');
         }
         if (!$this->input instanceof ListTablesInput) {
-            throw new \InvalidArgumentException('missing last request injected in paginated result');
+            throw new InvalidArgument('missing last request injected in paginated result');
         }
         $input = clone $this->input;
         $page = $this;
@@ -83,10 +84,10 @@ public function getTableNames(bool $currentPageOnly = false): iterable
 
         $client = $this->awsClient;
         if (!$client instanceof DynamoDbClient) {
-            throw new \InvalidArgumentException('missing client injected in paginated result');
+            throw new InvalidArgument('missing client injected in paginated result');
         }
         if (!$this->input instanceof ListTablesInput) {
-            throw new \InvalidArgumentException('missing last request injected in paginated result');
+            throw new InvalidArgument('missing last request injected in paginated result');
         }
         $input = clone $this->input;
         $page = $this;
diff --git a/src/Result/QueryOutput.php b/src/Result/QueryOutput.php
@@ -2,6 +2,7 @@
 
 namespace AsyncAws\DynamoDb\Result;
 
+use AsyncAws\Core\Exception\InvalidArgument;
 use AsyncAws\Core\Response;
 use AsyncAws\Core\Result;
 use AsyncAws\DynamoDb\DynamoDbClient;
@@ -81,10 +82,10 @@ public function getItems(bool $currentPageOnly = false): iterable
 
         $client = $this->awsClient;
         if (!$client instanceof DynamoDbClient) {
-            throw new \InvalidArgumentException('missing client injected in paginated result');
+            throw new InvalidArgument('missing client injected in paginated result');
         }
         if (!$this->input instanceof QueryInput) {
-            throw new \InvalidArgumentException('missing last request injected in paginated result');
+            throw new InvalidArgument('missing last request injected in paginated result');
         }
         $input = clone $this->input;
         $page = $this;
@@ -117,10 +118,10 @@ public function getIterator(): \Traversable
     {
         $client = $this->awsClient;
         if (!$client instanceof DynamoDbClient) {
-            throw new \InvalidArgumentException('missing client injected in paginated result');
+            throw new InvalidArgument('missing client injected in paginated result');
         }
         if (!$this->input instanceof QueryInput) {
-            throw new \InvalidArgumentException('missing last request injected in paginated result');
+            throw new InvalidArgument('missing last request injected in paginated result');
         }
         $input = clone $this->input;
         $page = $this;
diff --git a/src/Result/ScanOutput.php b/src/Result/ScanOutput.php
@@ -2,6 +2,7 @@
 
 namespace AsyncAws\DynamoDb\Result;
 
+use AsyncAws\Core\Exception\InvalidArgument;
 use AsyncAws\Core\Response;
 use AsyncAws\Core\Result;
 use AsyncAws\DynamoDb\DynamoDbClient;
@@ -81,10 +82,10 @@ public function getItems(bool $currentPageOnly = false): iterable
 
         $client = $this->awsClient;
         if (!$client instanceof DynamoDbClient) {
-            throw new \InvalidArgumentException('missing client injected in paginated result');
+            throw new InvalidArgument('missing client injected in paginated result');
         }
         if (!$this->input instanceof ScanInput) {
-            throw new \InvalidArgumentException('missing last request injected in paginated result');
+            throw new InvalidArgument('missing last request injected in paginated result');
         }
         $input = clone $this->input;
         $page = $this;
@@ -117,10 +118,10 @@ public function getIterator(): \Traversable
     {
         $client = $this->awsClient;
         if (!$client instanceof DynamoDbClient) {
-            throw new \InvalidArgumentException('missing client injected in paginated result');
+            throw new InvalidArgument('missing client injected in paginated result');
         }
         if (!$this->input instanceof ScanInput) {
-            throw new \InvalidArgumentException('missing last request injected in paginated result');
+            throw new InvalidArgument('missing last request injected in paginated result');
         }
         $input = clone $this->input;
         $page = $this;
diff --git a/src/Result/TableExistsWaiter.php b/src/Result/TableExistsWaiter.php
@@ -3,6 +3,7 @@
 namespace AsyncAws\DynamoDb\Result;
 
 use AsyncAws\Core\Exception\Http\HttpException;
+use AsyncAws\Core\Exception\InvalidArgument;
 use AsyncAws\Core\Response;
 use AsyncAws\Core\Waiter;
 use AsyncAws\DynamoDb\DynamoDbClient;
@@ -30,10 +31,10 @@ protected function extractState(Response $response, ?HttpException $exception):
     protected function refreshState(): Waiter
     {
         if (!$this->awsClient instanceof DynamoDbClient) {
-            throw new \InvalidArgumentException('missing client injected in waiter result');
+            throw new InvalidArgument('missing client injected in waiter result');
         }
         if (!$this->input instanceof DescribeTableInput) {
-            throw new \InvalidArgumentException('missing last request injected in waiter result');
+            throw new InvalidArgument('missing last request injected in waiter result');
         }
 
         return $this->awsClient->TableExists($this->input);
diff --git a/src/Result/TableNotExistsWaiter.php b/src/Result/TableNotExistsWaiter.php
@@ -3,6 +3,7 @@
 namespace AsyncAws\DynamoDb\Result;
 
 use AsyncAws\Core\Exception\Http\HttpException;
+use AsyncAws\Core\Exception\InvalidArgument;
 use AsyncAws\Core\Response;
 use AsyncAws\Core\Waiter;
 use AsyncAws\DynamoDb\DynamoDbClient;
@@ -26,10 +27,10 @@ protected function extractState(Response $response, ?HttpException $exception):
     protected function refreshState(): Waiter
     {
         if (!$this->awsClient instanceof DynamoDbClient) {
-            throw new \InvalidArgumentException('missing client injected in waiter result');
+            throw new InvalidArgument('missing client injected in waiter result');
         }
         if (!$this->input instanceof DescribeTableInput) {
-            throw new \InvalidArgumentException('missing last request injected in waiter result');
+            throw new InvalidArgument('missing last request injected in waiter result');
         }
 
         return $this->awsClient->TableNotExists($this->input);

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@`
`2`	`2`
`3`	`3`	`namespace AsyncAws\DynamoDb\Result;`
`4`	`4`
	`5`	`+use AsyncAws\Core\Exception\InvalidArgument;`
`5`	`6`	`use AsyncAws\Core\Response;`
`6`	`7`	`use AsyncAws\Core\Result;`
`7`	`8`	`use AsyncAws\DynamoDb\DynamoDbClient;`
`@@ -50,10 +51,10 @@ public function getConsumedCapacity(bool $currentPageOnly = false): iterable`
`50`	`51`
`51`	`52`	`$client = $this->awsClient;`
`52`	`53`	`if (!$client instanceof DynamoDbClient) {`
`53`		`- throw new \InvalidArgumentException('missing client injected in paginated result');`
	`54`	`+ throw new InvalidArgument('missing client injected in paginated result');`
`54`	`55`	`}`
`55`	`56`	`if (!$this->input instanceof BatchGetItemInput) {`
`56`		`- throw new \InvalidArgumentException('missing last request injected in paginated result');`
	`57`	`+ throw new InvalidArgument('missing last request injected in paginated result');`
`57`	`58`	`}`
`58`	`59`	`$input = clone $this->input;`
`59`	`60`	`$page = $this;`
`@@ -86,10 +87,10 @@ public function getIterator(): \Traversable`
`86`	`87`	`{`
`87`	`88`	`$client = $this->awsClient;`
`88`	`89`	`if (!$client instanceof DynamoDbClient) {`
`89`		`- throw new \InvalidArgumentException('missing client injected in paginated result');`
	`90`	`+ throw new InvalidArgument('missing client injected in paginated result');`
`90`	`91`	`}`
`91`	`92`	`if (!$this->input instanceof BatchGetItemInput) {`
`92`		`- throw new \InvalidArgumentException('missing last request injected in paginated result');`
	`93`	`+ throw new InvalidArgument('missing last request injected in paginated result');`
`93`	`94`	`}`
`94`	`95`	`$input = clone $this->input;`
`95`	`96`	`$page = $this;`
Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,7 @@`
`3`	`3`	`namespace AsyncAws\DynamoDb\Result;`
`4`	`4`
`5`	`5`	`use AsyncAws\Core\Exception\Http\HttpException;`
	`6`	`+use AsyncAws\Core\Exception\InvalidArgument;`
`6`	`7`	`use AsyncAws\Core\Response;`
`7`	`8`	`use AsyncAws\Core\Waiter;`
`8`	`9`	`use AsyncAws\DynamoDb\DynamoDbClient;`
`@@ -30,10 +31,10 @@ protected function extractState(Response $response, ?HttpException $exception):`
`30`	`31`	`protected function refreshState(): Waiter`
`31`	`32`	`{`
`32`	`33`	`if (!$this->awsClient instanceof DynamoDbClient) {`
`33`		`- throw new \InvalidArgumentException('missing client injected in waiter result');`
	`34`	`+ throw new InvalidArgument('missing client injected in waiter result');`
`34`	`35`	`}`
`35`	`36`	`if (!$this->input instanceof DescribeTableInput) {`
`36`		`- throw new \InvalidArgumentException('missing last request injected in waiter result');`
	`37`	`+ throw new InvalidArgument('missing last request injected in waiter result');`
`37`	`38`	`}`
`38`	`39`
`39`	`40`	`return $this->awsClient->TableExists($this->input);`