Skip to content

Commit 09182e6

Browse files
fix: use correct format
1 parent 31f8504 commit 09182e6

File tree

1 file changed

+9
-11
lines changed

1 file changed

+9
-11
lines changed

website/catalog/go/defer-func-call-antipattern.md

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,13 @@ defer require.NoError(t, failpoint.Disable("some/path"))
1515

1616
In this case, `failpoint.Disable("some/path")` is called immediately when the defer statement is reached, not when the function exits. This means the failpoint is disabled right after being enabled, making the test ineffective.
1717

18-
### YAML
19-
20-
```yaml
21-
id: defer-func-call-antipattern
22-
language: go
23-
rule:
24-
pattern: |
25-
defer $A.$B(t, failpoint.$M($$$))
26-
selector: defer_statement
18+
### Pattern
19+
20+
```shell
21+
ast-grep \
22+
--lang go \
23+
--pattern '{ defer $A.$B(t, failpoint.$M($$$)) } \
24+
--selector defer_statement'
2725
```
2826

2927
### Example
@@ -35,12 +33,12 @@ func TestIssue16696(t *testing.T) {
3533
vardef.MemoryUsageAlarmRatio.Store(0.0)
3634
defer vardef.MemoryUsageAlarmRatio.Store(alarmRatio)
3735
require.NoError(t, failpoint.Enable("github.com/pingcap/tidb/pkg/executor/sortexec/testSortedRowContainerSpill", "return(true)"))
38-
defer require.NoError(t,
36+
defer require.NoError(t,
3937
failpoint.Disable(
4038
"github.com/pingcap/tidb/pkg/executor/sortexec/testSortedRowContainerSpill"
4139
))
4240
require.NoError(t, failpoint.Enable("github.com/pingcap/tidb/pkg/executor/join/testRowContainerSpill", "return(true)"))
43-
defer require.NoError(t,
41+
defer require.NoError(t,
4442
failpoint.Disable("github.com/pingcap/tidb/pkg/executor/join/testRowContainerSpill"))
4543
}
4644
```

0 commit comments

Comments
 (0)