Parse long ranges #158

Tratcher · Tratcher · commit 1687e9ad955c · 2018-01-26T14:59:02.000-08:00
diff --git a/src/Microsoft.Owin.StaticFiles/Infrastructure/RangeHelpers.cs b/src/Microsoft.Owin.StaticFiles/Infrastructure/RangeHelpers.cs
@@ -82,9 +82,9 @@ internal static bool TryParseRanges(string rangeHeader, out IList<Tuple<long?, l
 
         private static bool TryParseLong(string input, out long? result)
         {
-            int temp;
+            long temp;
             if (!string.IsNullOrWhiteSpace(input)
-                && int.TryParse(input, NumberStyles.None, CultureInfo.InvariantCulture, out temp))
+                && long.TryParse(input, NumberStyles.None, CultureInfo.InvariantCulture, out temp))
             {
                 result = temp;
                 return true;
diff --git a/tests/Microsoft.Owin.StaticFiles.Tests/RangeHeaderTests.cs b/tests/Microsoft.Owin.StaticFiles.Tests/RangeHeaderTests.cs
@@ -226,6 +226,8 @@ public async Task HEADIfRangeWithoutRangeShouldServeFullContent()
         [InlineData("-26", "36-61", 26, "ABCDEFGHIJKLMNOPQRSTUVWXYZ")] // Last 26
         [InlineData("0-", "0-61", 62, "0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ")]
         [InlineData("-1001", "0-61", 62, "0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ")]
+        [InlineData("-123456789123", "0-61", 62, "0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ")]
+        [InlineData("36-123456789123", "36-61", 26, "ABCDEFGHIJKLMNOPQRSTUVWXYZ")]
         public async Task SingleValidRangeShouldServePartialContent(string range, string expectedRange, int length, string expectedData)
         {
             TestServer server = TestServer.Create(app => app.UseFileServer());

Original file line number	Diff line number	Diff line change
`@@ -82,9 +82,9 @@ internal static bool TryParseRanges(string rangeHeader, out IList<Tuple<long?, l`
`82`	`82`
`83`	`83`	`private static bool TryParseLong(string input, out long? result)`
`84`	`84`	`{`
`85`		`- int temp;`
	`85`	`+ long temp;`
`86`	`86`	`if (!string.IsNullOrWhiteSpace(input)`
`87`		`- && int.TryParse(input, NumberStyles.None, CultureInfo.InvariantCulture, out temp))`
	`87`	`+ && long.TryParse(input, NumberStyles.None, CultureInfo.InvariantCulture, out temp))`
`88`	`88`	`{`
`89`	`89`	`result = temp;`
`90`	`90`	`return true;`
Original file line number	Diff line number	Diff line change
`@@ -226,6 +226,8 @@ public async Task HEADIfRangeWithoutRangeShouldServeFullContent()`
`226`	`226`	`[InlineData("-26", "36-61", 26, "ABCDEFGHIJKLMNOPQRSTUVWXYZ")] // Last 26`
`227`	`227`	`[InlineData("0-", "0-61", 62, "0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ")]`
`228`	`228`	`[InlineData("-1001", "0-61", 62, "0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ")]`
	`229`	`+ [InlineData("-123456789123", "0-61", 62, "0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ")]`
	`230`	`+ [InlineData("36-123456789123", "36-61", 26, "ABCDEFGHIJKLMNOPQRSTUVWXYZ")]`
`229`	`231`	`public async Task SingleValidRangeShouldServePartialContent(string range, string expectedRange, int length, string expectedData)`
`230`	`232`	`{`
`231`	`233`	`TestServer server = TestServer.Create(app => app.UseFileServer());`