fix: print all error output to stderr when shim can't be resolved (#2109)

Author: Stratus3D

.tool-versions

@@ -1,4 +1,4 @@
 golang 1.23.4
 bats 1.8.2
-shellcheck 0.9.0
+shellcheck 0.10.0
 shfmt 3.6.0

cmd/asdf/main_test.go

@@ -5,6 +5,8 @@ import (
 	"os/exec"
 	"strings"
 	"testing"
+
+	"github.com/asdf-vm/asdf/internal/execute"
 )
 
 // Basic integration tests using the legacy BATS test scripts. This ensures the
@@ -124,9 +126,7 @@ func runBatsFile(t *testing.T, dir, filename string) {
 	cmd.Stderr = &stderr
 
 	// Add dir to asdf test variables
-	asdfTestHome := fmt.Sprintf("BASE_DIR=%s", dir)
-	asdfBinPath := fmt.Sprintf("ASDF_BIN=%s", dir)
-	cmd.Env = []string{asdfBinPath, asdfTestHome}
+	cmd.Env = execute.MergeWithCurrentEnv(map[string]string{"BASE_DIR": dir, "ASDF_BIN": dir})
 
 	err := cmd.Run()
 	if err != nil {

internal/cli/cli.go

@@ -666,16 +666,16 @@ func getExecutable(logger *log.Logger, conf config.Config, command string) (exec
 				logger.Printf("No preset version installed for command %s", command)
 				for _, toolVersion := range toolVersions {
 					for _, version := range toolVersion.Versions {
-						fmt.Printf("asdf install %s %s\n", toolVersion.Name, version)
+						logger.Printf("asdf install %s %s\n", toolVersion.Name, version)
 					}
 				}
 
-				fmt.Printf("or add one of the following versions in your config file at %s/.tool-versions\n", currentDir)
+				logger.Printf("or add one of the following versions in your config file at %s/.tool-versions\n", currentDir)
 			}
 
 			for _, toolVersion := range toolVersions {
 				for _, version := range toolVersion.Versions {
-					fmt.Printf("%s %s\n", toolVersion.Name, version)
+					logger.Printf("%s %s\n", toolVersion.Name, version)
 				}
 			}
 		}

test/shim_exec.bats

@@ -88,13 +88,14 @@ teardown() {
 
   touch "$PROJECT_DIR/.tool-versions"
 
-  run "$ASDF_DIR/shims/dummy" world hello
+  run --separate-stderr "$ASDF_DIR/shims/dummy" world hello
   [ "$status" -eq 126 ]
 
-  echo "$output" | grep -q "No version is set for command dummy" 2>/dev/null
-  echo "$output" | grep -q "Consider adding one of the following versions in your config file at $PROJECT_DIR/.tool-versions" 2>/dev/null
-  echo "$output" | grep -q "dummy 1.0" 2>/dev/null
-  echo "$output" | grep -q "dummy 2.0.0" 2>/dev/null
+  # shellcheck disable=SC2154
+  echo "${stderr:?}" | grep -q "No version is set for command dummy" 2>/dev/null
+  echo "${stderr:?}" | grep -q "Consider adding one of the following versions in your config file at $PROJECT_DIR/.tool-versions" 2>/dev/null
+  echo "${stderr:?}" | grep -q "dummy 1.0" 2>/dev/null
+  echo "${stderr:?}" | grep -q "dummy 2.0.0" 2>/dev/null
 }
 
 @test "shim exec should suggest different plugins providing same tool when no version is selected" {