chore: new architecture experiment revisited [DO NOT MERGE] #12825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
MounirDhahri
force-pushed
the
moplat/new-arch-revisited
branch
4 times, most recently
from
6cb25b0 to
841f693
Compare
MounirDhahri
force-pushed
the
moplat/new-arch-revisited
branch
from
841f693 to
f037931
Compare
|
I am opening the PR to make sure all CI stuff keeps on running |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Greptile Overview
Greptile Summary
Enables React Native new architecture experiment by setting newArchEnabled=true on both iOS and Android platforms and converting native modules to C++ (.mm).
- Enabled new architecture in
android/gradle.properties,ios/Podfile, andios/Podfile.properties.json - Converted
ARAppDelegateHelper.mandARPHPhotoPickerModule.mto.mm(Objective-C++) for new arch compilation compatibility - Updated
react-native-context-menu-viewandreact-native-launch-argumentsto fork branches with new architecture fixes - Added
startTransitionprop toFlagProviderto handle React 18 transitions - Bumped node cache version to v26
Issues found:
- Logic error in photo picker: checking
results.countinstead ofimages.countafter image loading could cause incorrect error handling
Additional Comments (1)
-
ios/Artsy/Emission/EigenCommunications/ARPHPhotoPickerModule.mm, line 96 (link)logic: checking
results.count == 0here is incorrect - should checkimages.count == 0since images may fail to load even when results exist
9 files reviewed, 2 comments
Comment on lines
+14
to
23
|
|
||
| #import <AuthenticationServices/AuthenticationServices.h> | ||
| #import <SafariServices/SafariServices.h> | ||
| #import <FBSDKCoreKit/FBSDKCoreKit-swift.h> | ||
|
|
||
|
|
||
| #import <Firebase.h> | ||
| #import "BrazeReactBridge.h" | ||
| #import "BrazeReactUtils.h" | ||
| #import <BrazeUI/BrazeUI-Swift.h> |
There was a problem hiding this comment.
style: added imports for AuthenticationServices and SafariServices when converting to C++, but these frameworks don't appear to be used - consider removing unused imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves []
Description
Experimental branch enabling the new architecture for testing.
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.