Mark C FFI handle getters from Structs as unsafe

Author: 9prady9

src/core/array.rs

@@ -367,7 +367,7 @@ where
     }
 
     /// Returns the native FFI handle for Rust object `Array`
-    pub fn get(&self) -> af_array {
+    pub unsafe fn get(&self) -> af_array {
         self.handle
     }
 
@@ -529,13 +529,11 @@ where
     /// Get the device pointer and lock the buffer in memory manager
     ///
     /// The device pointer is not freed by memory manager until unlock is called.
-    pub fn device_ptr(&self) -> void_ptr {
-        unsafe {
-            let mut temp: void_ptr = std::ptr::null_mut();
-            let err_val = af_get_device_ptr(&mut temp as *mut void_ptr, self.handle);
-            HANDLE_ERROR(AfError::from(err_val));
-            temp
-        }
+    pub unsafe fn device_ptr(&self) -> void_ptr {
+        let mut temp: void_ptr = std::ptr::null_mut();
+        let err_val = af_get_device_ptr(&mut temp as *mut void_ptr, self.handle);
+        HANDLE_ERROR(AfError::from(err_val));
+        temp
     }
 
     /// Get the size of physical allocated bytes.

src/core/data.rs

@@ -458,11 +458,11 @@ pub fn join_many<T>(dim: i32, inputs: Vec<&Array<T>>) -> Array<T>
 where
     T: HasAfEnum,
 {
-    let mut v = Vec::new();
-    for i in inputs {
-        v.push(i.get());
-    }
     unsafe {
+        let mut v = Vec::new();
+        for i in inputs {
+            v.push(i.get());
+        }
         let mut temp: af_array = std::ptr::null_mut();
         let err_val = af_join_many(
             &mut temp as *mut af_array,

src/core/index.rs

@@ -219,7 +219,7 @@ impl<'object> Indexer<'object> {
     }
 
     /// Get native(ArrayFire) resource handle
-    pub fn get(&self) -> af_index_t {
+    pub unsafe fn get(&self) -> af_index_t {
         self.handle
     }
 }

src/core/random.rs

@@ -183,7 +183,7 @@ impl RandomEngine {
     }
 
     /// Returns the native FFI handle for Rust object `RandomEngine`
-    pub fn get(&self) -> af_random_engine {
+    pub unsafe fn get(&self) -> af_random_engine {
         self.handle
     }
 }
@@ -219,7 +219,7 @@ pub fn get_default_random_engine() -> RandomEngine {
         let mut handle: af_random_engine = std::ptr::null_mut();
         err_val = af_retain_random_engine(&mut handle as *mut af_random_engine, temp);
         HANDLE_ERROR(AfError::from(err_val));
-        RandomEngine { handle: handle } //    ::from(handle)
+        RandomEngine { handle: handle }
     }
 }
 

src/vision/mod.rs

@@ -174,7 +174,7 @@ impl Features {
     feat_func_def!("Get features size Array", size, af_get_features_size);
 
     /// Get the internal handle for [Features](./struct.Features.html) object
-    pub fn get(&self) -> af_features {
+    pub unsafe fn get(&self) -> af_features {
         self.feat
     }
 }