Skip to content

Commit d42bac7

Browse files
authored
Merge pull request #2425 from appwrite/fix-horizontal-scroll
2 parents 05052aa + a145b61 commit d42bac7

File tree

5 files changed

+34
-16
lines changed

5 files changed

+34
-16
lines changed

.github/workflows/publish.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ jobs:
4141
"PUBLIC_CONSOLE_MODE=cloud"
4242
"PUBLIC_CONSOLE_FEATURE_FLAGS="
4343
"PUBLIC_APPWRITE_MULTI_REGION=true"
44+
"PUBLIC_CONSOLE_EMAIL_VERIFICATION=true"
4445
"PUBLIC_CONSOLE_MOCK_AI_SUGGESTIONS=false"
4546
"PUBLIC_GROWTH_ENDPOINT=${{ secrets.PUBLIC_GROWTH_ENDPOINT }}"
4647
"PUBLIC_STRIPE_KEY=${{ secrets.PUBLIC_STRIPE_KEY }}"
@@ -82,6 +83,7 @@ jobs:
8283
"PUBLIC_CONSOLE_MODE=cloud"
8384
"PUBLIC_CONSOLE_FEATURE_FLAGS="
8485
"PUBLIC_APPWRITE_MULTI_REGION=true"
86+
"PUBLIC_CONSOLE_EMAIL_VERIFICATION=false"
8587
"PUBLIC_CONSOLE_MOCK_AI_SUGGESTIONS=false"
8688
"PUBLIC_GROWTH_ENDPOINT=${{ secrets.PUBLIC_GROWTH_ENDPOINT }}"
8789
"PUBLIC_STRIPE_KEY=${{ secrets.PUBLIC_STRIPE_KEY_STAGE }}"
@@ -120,7 +122,8 @@ jobs:
120122
build-args: |
121123
"PUBLIC_CONSOLE_MODE=self-hosted"
122124
"PUBLIC_APPWRITE_MULTI_REGION=false"
123-
"PUBLIC_CONSOLE_MOCK_AI_SUGGESTIONS=false"
125+
"PUBLIC_CONSOLE_EMAIL_VERIFICATION=false"
126+
"PUBLIC_CONSOLE_MOCK_AI_SUGGESTIONS=true"
124127
"PUBLIC_CONSOLE_FEATURE_FLAGS="
125128
"PUBLIC_GROWTH_ENDPOINT=${{ secrets.PUBLIC_GROWTH_ENDPOINT }}"
126129
@@ -159,6 +162,7 @@ jobs:
159162
build-args: |
160163
"PUBLIC_CONSOLE_MODE=cloud"
161164
"PUBLIC_APPWRITE_MULTI_REGION=false"
165+
"PUBLIC_CONSOLE_EMAIL_VERIFICATION=true"
162166
"PUBLIC_CONSOLE_MOCK_AI_SUGGESTIONS=false"
163167
"PUBLIC_CONSOLE_FEATURE_FLAGS="
164168
"PUBLIC_STRIPE_KEY=${{ secrets.PUBLIC_STRIPE_KEY_STAGE }}"

Dockerfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ ADD ./static /app/static
2323
ARG PUBLIC_CONSOLE_MODE
2424
ARG PUBLIC_CONSOLE_FEATURE_FLAGS
2525
ARG PUBLIC_APPWRITE_MULTI_REGION
26+
ARG PUBLIC_CONSOLE_EMAIL_VERIFICATION
2627
ARG PUBLIC_CONSOLE_MOCK_AI_SUGGESTIONS
2728
ARG PUBLIC_APPWRITE_ENDPOINT
2829
ARG PUBLIC_GROWTH_ENDPOINT
@@ -35,6 +36,7 @@ ENV PUBLIC_GROWTH_ENDPOINT=$PUBLIC_GROWTH_ENDPOINT
3536
ENV PUBLIC_CONSOLE_MODE=$PUBLIC_CONSOLE_MODE
3637
ENV PUBLIC_CONSOLE_FEATURE_FLAGS=$PUBLIC_CONSOLE_FEATURE_FLAGS
3738
ENV PUBLIC_APPWRITE_MULTI_REGION=$PUBLIC_APPWRITE_MULTI_REGION
39+
ENV PUBLIC_CONSOLE_EMAIL_VERIFICATION=$PUBLIC_CONSOLE_EMAIL_VERIFICATION
3840
ENV PUBLIC_CONSOLE_MOCK_AI_SUGGESTIONS=$PUBLIC_CONSOLE_MOCK_AI_SUGGESTIONS
3941
ENV PUBLIC_STRIPE_KEY=$PUBLIC_STRIPE_KEY
4042
ENV SENTRY_AUTH_TOKEN=$SENTRY_AUTH_TOKEN

build.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ async function main() {
2828
logEnv('MULTI REGION', env?.PUBLIC_APPWRITE_MULTI_REGION);
2929
logEnv('APPWRITE ENDPOINT', env?.PUBLIC_APPWRITE_ENDPOINT, 'relative');
3030
logEnv('GROWTH ENDPOINT', env?.PUBLIC_GROWTH_ENDPOINT);
31+
logEnv('CONSOLE EMAIL VERIFICATION', env?.PUBLIC_CONSOLE_EMAIL_VERIFICATION);
32+
logEnv('CONSOLE MOCK AI SUGGESTIONS', env?.PUBLIC_CONSOLE_MOCK_AI_SUGGESTIONS);
3133
log();
3234
logDelimiter();
3335
await build();

src/lib/components/alerts/emailVerificationBanner.svelte

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,14 @@
66
import SendVerificationEmailModal from '../account/sendVerificationEmailModal.svelte';
77
import { page } from '$app/state';
88
import { wizard, isNewWizardStatusOpen } from '$lib/stores/wizard';
9-
import { isCloud, isProductionCloud, VARS } from '$lib/system';
9+
import { isCloud, VARS } from '$lib/system';
1010
1111
const hasUser = $derived(!!$user);
1212
const needsEmailVerification = $derived(hasUser && !$user.emailVerification);
1313
const notOnOnboarding = $derived(!page.route.id.includes('/onboarding'));
1414
const notOnWizard = $derived(!$wizard.show && !$isNewWizardStatusOpen);
15-
const isEnabledViaEnvConfig = $derived(VARS.EMAIL_VERIFICATION);
1615
const shouldShowEmailBanner = $derived(
17-
isEnabledViaEnvConfig &&
16+
VARS.EMAIL_VERIFICATION &&
1817
isCloud &&
1918
hasUser &&
2019
needsEmailVerification &&
@@ -23,10 +22,9 @@
2322
);
2423
2524
let showSendVerification = $state(false);
26-
let isProduction = $derived(isProductionCloud(page.url));
2725
</script>
2826

29-
{#if shouldShowEmailBanner && isProduction}
27+
{#if shouldShowEmailBanner}
3028
<HeaderAlert type="warning" title="Your email address needs to be verified">
3129
<svelte:fragment>
3230
To avoid losing access to your projects, make sure <Typography.Text

src/routes/(console)/project-[region]-[project]/databases/database-[database]/(suggestions)/empty.svelte

Lines changed: 22 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -451,16 +451,28 @@
451451
452452
const mappedColumns = mapSuggestedColumns(suggestedColumns.columns);
453453
454+
// replace with actual columns and trim excess
455+
if (mappedColumns.length < customColumns.length) {
456+
customColumns = customColumns.slice(0, mappedColumns.length);
457+
}
458+
459+
// replace existing placeholders and
460+
// add any additional columns if needed
454461
mappedColumns.forEach((column, index) => {
455-
if (index < customColumns.length) {
456-
setTimeout(() => {
462+
setTimeout(() => {
463+
if (index < customColumns.length) {
464+
// replace existing placeholder
457465
customColumns[index] = { ...column, isPlaceholder: false };
466+
} else {
467+
// new column directly if we have more than expected
468+
// just added in case the max ever changes on backend!
469+
customColumns.push({ ...column, isPlaceholder: false });
470+
}
458471
459-
// recalculate overlay bounds
460-
// after each column is populated!
461-
requestAnimationFrame(() => updateOverlayBounds());
462-
}, index * 150);
463-
}
472+
// recalculate overlay bounds
473+
// after each column is populated!
474+
requestAnimationFrame(() => updateOverlayBounds());
475+
}, index * 150);
464476
});
465477
466478
if (mappedColumns.length > 0) {
@@ -1047,7 +1059,7 @@
10471059
.spreadsheet-container-outer {
10481060
width: 100%;
10491061
position: fixed;
1050-
overflow: hidden;
1062+
overflow: visible;
10511063
scrollbar-width: none;
10521064
10531065
&.custom-columns {
@@ -1174,8 +1186,8 @@
11741186
}
11751187
11761188
& :global(.spreadsheet-container) {
1177-
overflow-x: hidden;
1178-
overflow-y: hidden;
1189+
overflow-x: auto;
1190+
overflow-y: auto;
11791191
scrollbar-width: none;
11801192
}
11811193

0 commit comments

Comments
 (0)