Bump parent from 42 to 45

- bump parent
- fix checkstyle issues
- fix ITs
- disable ci-friendly-multi-module IT for Maven 4

Author: slawekjaranowski

.github/dependabot.yml

@@ -21,9 +21,6 @@ updates:
     directory: "/"
     schedule:
       interval: "daily"
-    ignore:
-      # Ignore Maven Core updates
-      - dependency-name: "org.apache.maven:*"
   - package-ecosystem: "github-actions"
     directory: "/"
     schedule:

maven-release-manager/pom.xml

@@ -30,6 +30,10 @@
 
   <name>Maven Release Manager</name>
 
+  <properties>
+    <checkstyle.violation.ignore>FileLength</checkstyle.violation.ignore>
+  </properties>
+
   <dependencies>
     <dependency>
       <groupId>org.apache.maven.release</groupId>

maven-release-manager/src/main/java/org/apache/maven/shared/release/config/PropertiesReleaseDescriptorStore.java

@@ -137,6 +137,7 @@ public void delete(ReleaseDescriptor config) {
      * @param file   a {@link java.io.File} object
      * @throws org.apache.maven.shared.release.config.ReleaseDescriptorStoreException if any.
      */
+    @SuppressWarnings("checkstyle:MethodLength")
     public void write(BuilderReleaseDescriptor config, File file) throws ReleaseDescriptorStoreException {
         Properties properties = new Properties();
         properties.setProperty("completedPhase", config.getCompletedPhase());

maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java

@@ -608,6 +608,7 @@ private void rewriteArtifactVersion(
      * @param releaseDescriptor
      * @return {@code true} if the property was rewritten, otherwise {@code false}
      */
+    @SuppressWarnings("checkstyle:ParameterNumber")
     boolean rewritePropertyUsedInVersionExpression(
             String projectKey,
             String artifactKey,

maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/AbstractRewritingReleasePhaseTestCase.java

@@ -519,7 +519,6 @@ public void testRewriteBasicPomWithNoSuchProviderException() throws Exception {
         ScmManager scmManager = (ScmManager) lookup(ScmManager.class);
         if (scmManager instanceof ScmManagerStub) {
             ((ScmManagerStub) scmManager).setException(new NoSuchScmProviderException("..."));
-            ;
         }
 
         // execute

maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/CheckDependencySnapshotsPhaseTest.java

@@ -68,7 +68,7 @@ public void setUp() throws Exception {
     @Test
     public void testNoSnapshotDependencies() throws Exception {
         ReleaseDescriptorBuilder builder = new ReleaseDescriptorBuilder();
-        ;
+
         List<MavenProject> reactorProjects = createDescriptorFromProjects("no-snapshot-dependencies");
 
         phase.execute(ReleaseUtils.buildReleaseDescriptor(builder), new DefaultReleaseEnvironment(), reactorProjects);
@@ -609,7 +609,7 @@ public void testSnapshotDependenciesInsideAndOutsideProject() throws Exception {
     @Test
     public void testNoSnapshotReportPlugins() throws Exception {
         ReleaseDescriptorBuilder builder = new ReleaseDescriptorBuilder();
-        ;
+
         List<MavenProject> reactorProjects = createDescriptorFromProjects("no-snapshot-report-plugins");
 
         phase.execute(ReleaseUtils.buildReleaseDescriptor(builder), new DefaultReleaseEnvironment(), reactorProjects);
@@ -699,7 +699,7 @@ public void testSnapshotReportPluginsInsideAndOutsideProject() throws Exception
     @Test
     public void testNoSnapshotPlugins() throws Exception {
         ReleaseDescriptorBuilder builder = new ReleaseDescriptorBuilder();
-        ;
+
         List<MavenProject> reactorProjects = createDescriptorFromProjects("no-snapshot-plugins");
 
         phase.execute(ReleaseUtils.buildReleaseDescriptor(builder), new DefaultReleaseEnvironment(), reactorProjects);
@@ -910,7 +910,7 @@ public void testSnapshotExternalParentAdjusted() throws Exception {
     @Test
     public void testReleaseExternalParent() throws Exception {
         ReleaseDescriptorBuilder builder = new ReleaseDescriptorBuilder();
-        ;
+
         List<MavenProject> reactorProjects = createDescriptorFromProjects("external-parent/child");
 
         phase.execute(ReleaseUtils.buildReleaseDescriptor(builder), new DefaultReleaseEnvironment(), reactorProjects);
@@ -968,7 +968,7 @@ public void testSnapshotInternalExtension() throws Exception {
     @Test
     public void testReleaseExternalExtension() throws Exception {
         ReleaseDescriptorBuilder builder = new ReleaseDescriptorBuilder();
-        ;
+
         List<MavenProject> reactorProjects = createDescriptorFromProjects("external-extension");
 
         phase.execute(ReleaseUtils.buildReleaseDescriptor(builder), new DefaultReleaseEnvironment(), reactorProjects);
@@ -1088,7 +1088,7 @@ private static class VersionPair {
 
         String developmentVersion;
 
-        public VersionPair(String releaseVersion, String developmentVersion) {
+        VersionPair(String releaseVersion, String developmentVersion) {
             this.releaseVersion = releaseVersion;
             this.developmentVersion = developmentVersion;
         }

maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/MapVersionsPhaseTest.java

@@ -84,7 +84,6 @@ public void testFlushPluginMap() {
     @Test(expected = UnsupportedOperationException.class)
     public void testAddExtension() {
         new JDomBuild(null).addExtension(null);
-        ;
     }
 
     @Test(expected = UnsupportedOperationException.class)
@@ -120,7 +119,6 @@ public void testRemoveExtension() {
     @Test(expected = UnsupportedOperationException.class)
     public void testSetExtensions() {
         new JDomBuild(null).setExtensions(null);
-        ;
     }
 
     @Test(expected = UnsupportedOperationException.class)

maven-release-manager/src/test/java/org/apache/maven/shared/release/transform/jdom2/JDomBuildTest.java

@@ -106,25 +106,21 @@ public void testGetVersion() throws Exception {
     @Test(expected = UnsupportedOperationException.class)
     public void testRemoveExclusion() {
         new JDomDependency(null).removeExclusion(null);
-        ;
     }
 
     @Test(expected = UnsupportedOperationException.class)
     public void testSetArtifactIdString() {
         new JDomDependency(null).setArtifactId(null);
-        ;
     }
 
     @Test(expected = UnsupportedOperationException.class)
     public void testSetClassifierString() {
         new JDomDependency(null).setClassifier(null);
-        ;
     }
 
     @Test(expected = UnsupportedOperationException.class)
     public void testSetExclusions() {
         new JDomDependency(null).setExclusions(null);
-        ;
     }
 
     @Test(expected = UnsupportedOperationException.class)

maven-release-manager/src/test/java/org/apache/maven/shared/release/transform/jdom2/JDomDependencyTest.java

@@ -26,7 +26,8 @@
 import org.jdom2.input.SAXBuilder;
 import org.junit.Test;
 
-import static org.junit.Assert.*;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNull;
 
 public class JDomParentTest {
     private SAXBuilder builder = new SAXBuilder();