[MCHECKSTYLE-412] Exclude generated sources / test-sources from default source / test-source directories

Author: gmshake

src/main/java/org/apache/maven/plugins/checkstyle/AbstractCheckstyleReport.java

@@ -25,6 +25,7 @@
 import java.io.FileOutputStream;
 import java.io.IOException;
 import java.io.OutputStream;
+import java.nio.file.Path;
 import java.util.ArrayList;
 import java.util.Calendar;
 import java.util.List;
@@ -826,7 +827,7 @@ protected List<File> getSourceDirectories()
     {
         if ( sourceDirectories == null )
         {
-            sourceDirectories = project.getCompileSourceRoots();
+            sourceDirectories = filterBuildTarget( project.getCompileSourceRoots() );
         }
         List<File> sourceDirs = new ArrayList<>( sourceDirectories.size() );
         for ( String sourceDir : sourceDirectories )
@@ -840,7 +841,7 @@ protected List<File> getTestSourceDirectories()
     {
         if ( testSourceDirectories == null )
         {
-            testSourceDirectories = project.getTestCompileSourceRoots();
+            testSourceDirectories = filterBuildTarget( project.getTestCompileSourceRoots() );
         }
         List<File> testSourceDirs = new ArrayList<>( testSourceDirectories.size() );
         for ( String testSourceDir : testSourceDirectories )
@@ -849,4 +850,21 @@ protected List<File> getTestSourceDirectories()
         }
         return testSourceDirs;
     }
+
+    private List<String> filterBuildTarget( List<String> sourceDirectories )
+    {
+        List<String> filtered = new ArrayList<>( sourceDirectories.size() );
+        Path buildTarget = FileUtils.resolveFile( project.getBasedir(), project.getBuild().getDirectory() )
+                .toPath();
+
+        for ( String sourceDir : sourceDirectories )
+        {
+            Path src = FileUtils.resolveFile( project.getBasedir(), sourceDir ).toPath();
+            if ( !src.startsWith( buildTarget ) )
+            {
+                filtered.add( sourceDir );
+            }
+        }
+        return filtered;
+    }
 }

src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationCheckMojo.java

@@ -27,6 +27,7 @@
 import java.io.IOException;
 import java.io.OutputStream;
 import java.io.Reader;
+import java.nio.file.Path;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
@@ -913,7 +914,7 @@ private List<File> getSourceDirectories()
     {
         if ( sourceDirectories == null )
         {
-            sourceDirectories = project.getCompileSourceRoots();
+            sourceDirectories = filterBuildTarget( project.getCompileSourceRoots() );
         }
         List<File> sourceDirs = new ArrayList<>( sourceDirectories.size() );
         for ( String sourceDir : sourceDirectories )
@@ -927,7 +928,7 @@ private List<File> getTestSourceDirectories()
     {
         if ( testSourceDirectories == null )
         {
-            testSourceDirectories = project.getTestCompileSourceRoots();
+            testSourceDirectories = filterBuildTarget( project.getTestCompileSourceRoots() );
         }
         List<File> testSourceDirs = new ArrayList<>( testSourceDirectories.size() );
         for ( String testSourceDir : testSourceDirectories )
@@ -936,5 +937,21 @@ private List<File> getTestSourceDirectories()
         }
         return testSourceDirs;
     }
-    
+
+    private List<String> filterBuildTarget( List<String> sourceDirectories )
+    {
+        List<String> filtered = new ArrayList<>( sourceDirectories.size() );
+        Path buildTarget = FileUtils.resolveFile( project.getBasedir(), project.getBuild().getDirectory() )
+                .toPath();
+
+        for ( String sourceDir : sourceDirectories )
+        {
+            Path src = FileUtils.resolveFile( project.getBasedir(), sourceDir ).toPath();
+            if ( !src.startsWith( buildTarget ) )
+            {
+                filtered.add( sourceDir );
+            }
+        }
+        return filtered;
+    }
 }

src/test/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationCheckMojoTest.java

@@ -21,6 +21,8 @@
 
 import java.io.File;
 import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
 
 import org.apache.maven.model.Build;
 import org.apache.maven.plugin.Mojo;
@@ -175,6 +177,16 @@ public File getFile()
                 return new File( getBasedir(), "target/classes" );
             }
 
+            @Override
+            public List<String> getCompileSourceRoots() {
+                return Collections.emptyList();
+            }
+
+            @Override
+            public List<String> getTestCompileSourceRoots() {
+                return Collections.emptyList();
+            }
+
             public Build getBuild()
             {
                 return new Build()