Skip to content

Commit 5aed527

Browse files
committed
chore: Remaining coderabbit comments
1 parent 1815705 commit 5aed527

File tree

3 files changed

+14
-14
lines changed

3 files changed

+14
-14
lines changed

.pre-commit-hooks.yaml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@
186186
Rewrites all Terraform configuration files to a canonical format using Docker.
187187
NOTE: Requires Docker to be available. Use 'skip' in .pre-commit-config.yaml
188188
if running on pre-commit.ci or other environments without Docker.
189-
entry: ghcr.io/actuarysailor/pre-commit-terraform-tools:latest
189+
entry: ghcr.io/antonbabenko/pre-commit-terraform-tools:latest
190190
language: docker_image
191191
args: [terraform, fmt]
192192
files: \.(tf|tofu|tfvars|tftest\.hcl|tfmock\.hcl)$
@@ -201,7 +201,7 @@
201201
NOTE: Requires Docker to be available. Use 'skip' in .pre-commit-config.yaml
202202
if running on pre-commit.ci or other environments without Docker.
203203
require_serial: true
204-
entry: ghcr.io/actuarysailor/pre-commit-terraform-tools:latest
204+
entry: ghcr.io/antonbabenko/pre-commit-terraform-tools:latest
205205
language: docker_image
206206
args:
207207
- /usr/bin/hooks/terraform_validate.sh
@@ -220,7 +220,7 @@
220220
NOTE: Requires Docker to be available. Use 'skip' in .pre-commit-config.yaml
221221
if running on pre-commit.ci or other environments without Docker.
222222
require_serial: true
223-
entry: ghcr.io/actuarysailor/pre-commit-terraform-tools:latest
223+
entry: ghcr.io/antonbabenko/pre-commit-terraform-tools:latest
224224
language: docker_image
225225
args: [tflint, --chdir=.]
226226
pass_filenames: false
@@ -234,7 +234,7 @@
234234
NOTE: Requires Docker to be available. Use 'skip' in .pre-commit-config.yaml
235235
if running on pre-commit.ci or other environments without Docker.
236236
require_serial: true
237-
entry: ghcr.io/actuarysailor/pre-commit-terraform-tools:latest
237+
entry: ghcr.io/antonbabenko/pre-commit-terraform-tools:latest
238238
language: docker_image
239239
args: [terraform-docs, markdown, table, ., --output-file, README.md]
240240
pass_filenames: false
@@ -247,7 +247,7 @@
247247
Runs checkov on Terraform templates using Docker.
248248
NOTE: Requires Docker to be available. Use 'skip' in .pre-commit-config.yaml
249249
if running on pre-commit.ci or other environments without Docker.
250-
entry: ghcr.io/actuarysailor/pre-commit-terraform-tools:latest
250+
entry: ghcr.io/antonbabenko/pre-commit-terraform-tools:latest
251251
language: docker_image
252252
args: [checkov, -d, .]
253253
pass_filenames: false
@@ -264,7 +264,7 @@
264264
NOTE: Requires Docker to be available. Use 'skip' in .pre-commit-config.yaml
265265
if running on pre-commit.ci or other environments without Docker.
266266
require_serial: true
267-
entry: ghcr.io/actuarysailor/pre-commit-terraform-tools:latest
267+
entry: ghcr.io/antonbabenko/pre-commit-terraform-tools:latest
268268
language: docker_image
269269
args: [trivy, config, .]
270270
pass_filenames: false
@@ -277,7 +277,7 @@
277277
Check terraform infrastructure cost using Docker.
278278
NOTE: Requires Docker to be available. Use 'skip' in .pre-commit-config.yaml
279279
if running on pre-commit.ci or other environments without Docker.
280-
entry: ghcr.io/actuarysailor/pre-commit-terraform-tools:latest
280+
entry: ghcr.io/antonbabenko/pre-commit-terraform-tools:latest
281281
language: docker_image
282282
args: [infracost, breakdown, --path, .]
283283
pass_filenames: false

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ TAG=latest
9494
docker pull ghcr.io/antonbabenko/pre-commit-terraform:$TAG
9595
```
9696

97-
All available tags are [available on GitHub Container Registry](https://github.com/antonbabenko/pre-commit-terraform/pkgs/container/pre-commit-terraform/versions).
97+
All tags are [available on GitHub Container Registry](https://github.com/antonbabenko/pre-commit-terraform/pkgs/container/pre-commit-terraform/versions).
9898

9999
Check [About Docker image security](#about-docker-image-security) section to learn more about possible security issues and why you probably want to build and maintain your own image.
100100

@@ -365,7 +365,7 @@ For users who prefer not to install tools locally, Docker-based versions are ava
365365
**Requirements and limitations:**
366366

367367
* Docker must be installed and accessible
368-
* For pre-commit.ci users: At this time, these hooks must be skipped as pre-commit.ci agents do not have Docker available.
368+
* For pre-commit.ci users: At this time, skip these hooks because pre-commit.ci agents do not have Docker available.
369369
* _Note: pre-commit has a Docker setup for hooks, so Docker support may be added in the future._
370370
* **You can still use Docker-based hooks in CI/CD pipelines** (such as GitHub Actions, GitLab CI, etc.) by running `pre-commit run --all-files` (or `pre-commit run -a`) on a self-hosted or GitHub-hosted runner where Docker is available. This allows you to enforce the same checks in CI as locally, even if pre-commit.ci does not support Docker yet.
371371

@@ -427,7 +427,7 @@ You can specify environment variables that will be passed to the hook at runtime
427427
> [!IMPORTANT]
428428
> Variable values are exported _verbatim_:
429429
>
430-
> * No interpolation or expansion are applied
430+
> * No interpolation or expansion is applied
431431
> * The enclosing double quotes are removed if they are provided
432432

433433
Config example:
@@ -1272,7 +1272,7 @@ The [recommended command](#4-run) to run the Docker container is:
12721272

12731273
```bash
12741274
TAG=latest
1275-
docker run -e "USERID=$(id -u):$(id -g)" -v $(pwd):/lint -w /lint ghcr.io/antonbabenko/pre-commit-terraform:$TAG run -a
1275+
docker run -e "USERID=$(id -u):$(id -g)" -v "$(pwd):/lint" -w "/lint" ghcr.io/antonbabenko/pre-commit-terraform:latest run -a
12761276
```
12771277

12781278
which uses your current session's user ID and group ID to set the variable in the run command. Without this setting, you may find files and directories owned by `root` in your local repository.

examples/.pre-commit-config-docker.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ ci:
1313
- infracost_breakdown_docker
1414

1515
repos:
16-
- repo: https://github.com/actuarysailor/pre-commit-terraform
16+
- repo: https://github.com/antonbabenko/pre-commit-terraform
1717
rev: v1.96.1 # Use a stable release version
1818
hooks:
1919
# Option 1: Use Docker-based hooks (no local tool installation required)
@@ -51,7 +51,7 @@ repos:
5151
# ⚠️ Need to ensure Docker image is available (pull or build)
5252

5353
# Build the tools image locally with:
54-
# docker build -f Dockerfile.tools -t ghcr.io/actuarysailor/pre-commit-terraform-tools:latest .
54+
# docker build -f Dockerfile.tools -t ghcr.io/antonbabenko/pre-commit-terraform-tools:latest .
5555

5656
# Or use the pre-built image once published:
57-
# docker pull ghcr.io/actuarysailor/pre-commit-terraform-tools:latest
57+
# docker pull ghcr.io/antonbabenko/pre-commit-terraform-tools:latest

0 commit comments

Comments
 (0)