Feature/gotestfix (#4168)

* fix: Fixes the failing go runtime test suite which was missing the /v4 off the replace option on the go.mod file

Arrrgh!

Signed-off-by: Jim.Idle <[email protected]>

* present antlr before versioning (#4156)

Signed-off-by: Jim.Idle <[email protected]>

* fix: Prevent use of labels such as start= from generating code that clashes with builtin funcs (#4161)

Signed-off-by: Jim.Idle <[email protected]>

* fix: Cater for the fact that some test rules use start as a label or rule name

As a fix for other cvode gen errors when start, end, or exception are used as
label names, they are now translated to have a suffix of `_` at code gen time.
However, the runtime tests sometimes use start as a rule name and so we must now
cater for this in the tests.

Signed-off-by: Jim.Idle <[email protected]>

---------

Signed-off-by: Jim.Idle <[email protected]>
Co-authored-by: ericvergnaud <[email protected]>

Author: Jim Idle

runtime-testsuite/test/org/antlr/v4/test/runtime/go/GoRunner.java

@@ -85,8 +85,8 @@ protected void initRuntime(RunOptions runOptions) throws Exception {
 		if (goModFile.exists())
 			if (!goModFile.delete())
 				throw new IOException("Can't delete " + goModFile);
-		Processor.run(new String[] {runtimeToolPath, "mod", "init", "test"}, cachePath, environment);
-		Processor.run(new String[] {runtimeToolPath, "mod", "edit",
+		Processor.run(new String[]{runtimeToolPath, "mod", "init", "test"}, cachePath, environment);
+		Processor.run(new String[]{runtimeToolPath, "mod", "edit",
 				"-replace=" + GoRuntimeImportPath + "=" + runtimeFilesPath}, cachePath, environment);
 		cachedGoMod = readFile(cachePath + FileSeparator, "go.mod");
 	}
@@ -97,7 +97,18 @@ protected String grammarParseRuleToRecognizerName(String startRuleName) {
 			return null;
 		}
 
-		return startRuleName.substring(0, 1).toUpperCase() + startRuleName.substring(1);
+		// The rule name start is now translated to Start_ at runtime to avoid clashes with labels.
+		// Some tests use start as the first rule name, and we must cater for that
+		//
+		String rn = startRuleName.substring(0, 1).toUpperCase() + startRuleName.substring(1);
+		switch (rn) {
+			case "Start":
+			case "End":
+			case "Exception":
+				rn += "_";
+			default:
+		}
+		return rn;
 	}
 
 	@Override
@@ -126,7 +137,7 @@ protected CompiledState compile(RunOptions runOptions, GeneratedState generatedS
 		writeFile(tempDirPath, "go.mod", cachedGoMod);
 		Exception ex = null;
 		try {
-			Processor.run(new String[] {getRuntimeToolPath(), "mod", "tidy"}, tempDirPath, environment);
+			Processor.run(new String[]{getRuntimeToolPath(), "mod", "tidy"}, tempDirPath, environment);
 		} catch (InterruptedException | IOException e) {
 			ex = e;
 		}