Skip to content

Commit 2bd5d13

Browse files
jimidleparrt
authored andcommitted
doc: Update TODO comment in prediction_context now that #3967 is fixed
Signed-off-by: Jim.Idle <[email protected]>
1 parent 06028ef commit 2bd5d13

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

runtime/Go/antlr/v4/prediction_context.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -400,8 +400,7 @@ func mergeArrays(a, b *ArrayPredictionContext, rootIsWildcard bool, mergeCache *
400400
M := NewArrayPredictionContext(mergedParents, mergedReturnStates)
401401

402402
// if we created same array as a or b, return that instead
403-
// TODO: JI track whether this is possible above during merge sort for speed
404-
// TODO: JI VERY IMPORTANT - In go, I do not think we can just do M == xx as M is a brand new allocation. This could be causing allocation problems
403+
// TODO: JI track whether this is possible above during merge sort for speed and possibly avoid an allocation
405404
if M.Equals(a) {
406405
if mergeCache != nil {
407406
mergeCache.set(a.Hash(), b.Hash(), a)

0 commit comments

Comments
 (0)