This repository was archived by the owner on May 12, 2022. It is now read-only.
feat: support tsconfig-paths #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
reviewed
Nov 2, 2021
|
Generally, it LGTM 👍. Can you help on checking the issue on Windows? |
Oops, but I currently don't own a windows. It seems the path in the shell command can't include the disk symbol, but I'm not able to run a full test. I have already fixed that using |
|
It's passing. Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should close #8
The main logic is added to
loader.resolve, where we use the resolved tsconfig to map the "absolute path" to real path.Note that typescript considers path mapping to have the highest precedence compared to node resolution rule, the added logic should be added at the beginning of
loader.resolve. However, since this is how typescript behaves, this change is breaking, but shouldn't affect too many users.Plus, I modified extensionsRegex to support
.mtsextension, following the latest change in TypeScript 4.5.Tests are added to
test/tsconfig-paths.