Skip to content

Commit fe62676

Browse files
Bump kotlin from 2.0.21 to 2.1.0 (#259)
1 parent ca48fb0 commit fe62676

File tree

8 files changed

+32
-39
lines changed

8 files changed

+32
-39
lines changed

compiler/build.gradle.kts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ plugins {
66
kotlin("kapt")
77
id("library")
88
id("library.publishing")
9-
id("com.gradleup.shadow")
109
`java-test-fixtures`
1110
}
1211

@@ -18,18 +17,15 @@ dependencies {
1817
implementation(libs.dagger)
1918
implementation(libs.dagger.hilt.core)
2019
implementation(libs.ksp.api)
21-
implementation(libs.auto.common)
20+
api(libs.auto.common)
21+
implementation(libs.kotlin.metadata)
2222

2323
implementation(projects.core)
2424
implementation(projects.android.testing)
2525
implementation(projects.thirdParty.androidx.room)
2626
implementation(projects.thirdParty.ktorfit)
2727
implementation(projects.thirdParty.retrofit)
28-
2928
implementation(projects.compiler.common)
30-
compileShaded(libs.kotlinx.metadata) {
31-
exclude("org.jetbrains.kotlin", "kotlin-stdlib")
32-
}
3329

3430
implementation(libs.auto.service.annotations)
3531
kapt(libs.auto.service)
@@ -41,4 +37,5 @@ dependencies {
4137
testFixturesApi(libs.dagger)
4238
testFixturesApi(libs.dagger.hilt.core)
4339
testFixturesApi(libs.bundles.compileTesting)
40+
testFixturesApi(projects.compiler.common)
4441
}

compiler/common/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ plugins {
55
}
66

77
dependencies {
8-
compileOnly(libs.kotlinx.metadata)
8+
compileOnly(libs.kotlin.metadata)
99
compileOnly(libs.javapoet)
1010
compileOnly(libs.bundles.kotlinpoet)
1111
implementation(libs.dagger)

compiler/common/test-utils/build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@ plugins {
66
}
77

88
dependencies {
9-
api(projects.compiler.common.apply { targetConfiguration = "shadow" })
9+
api(projects.compiler.common)
1010
api(libs.bundles.jvmTesting)
1111
api(libs.dagger.hilt.core)
12-
api(libs.kotlinx.metadata)
12+
api(libs.kotlin.metadata)
1313
api(libs.ksp.api)
1414
api(libs.bundles.compileTesting)
1515
api(libs.okio)

compiler/src/main/kotlin/se/ansman/dagger/auto/compiler/kapt/processing/KaptClassDeclaration.kt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@ import com.google.auto.common.MoreElements
44
import com.squareup.javapoet.AnnotationSpec
55
import com.squareup.javapoet.ClassName
66
import com.squareup.javapoet.TypeName
7-
import kotlinx.metadata.ClassKind
8-
import kotlinx.metadata.Modality
9-
import kotlinx.metadata.Visibility
10-
import kotlinx.metadata.kind
11-
import kotlinx.metadata.modality
12-
import kotlinx.metadata.visibility
7+
import kotlin.metadata.ClassKind
8+
import kotlin.metadata.Modality
9+
import kotlin.metadata.Visibility
10+
import kotlin.metadata.kind
11+
import kotlin.metadata.modality
12+
import kotlin.metadata.visibility
1313
import se.ansman.dagger.auto.compiler.common.processing.ClassDeclaration
1414
import javax.lang.model.element.Element
1515
import javax.lang.model.element.ElementKind

compiler/src/main/kotlin/se/ansman/dagger/auto/compiler/kapt/processing/KaptResolver.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import com.google.common.collect.ImmutableSetMultimap
55
import com.squareup.javapoet.AnnotationSpec
66
import com.squareup.javapoet.ClassName
77
import com.squareup.javapoet.TypeName
8-
import kotlinx.metadata.jvm.KotlinClassMetadata
8+
import kotlin.metadata.jvm.KotlinClassMetadata
99
import se.ansman.dagger.auto.compiler.common.TypeLookup
1010
import se.ansman.dagger.auto.compiler.common.processing.AutoDaggerResolver
1111
import se.ansman.dagger.auto.compiler.common.processing.ClassDeclaration

compiler/src/testFixtures/kotlin/se/ansman/dagger/auto/compiler/KspCompilation.kt

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -28,30 +28,17 @@ class KspCompilation(
2828
symbolProcessorProviders.addAll(processorProviders())
2929
}
3030
}
31-
.compileFixed()
31+
.compile()
3232
.let(::Result)
3333

34-
private fun KotlinCompilation.compileFixed(): JvmCompilationResult {
35-
return compile()
36-
// val result = synchronized(mutex) { compile() }
37-
// // This works around a bug where compile-testing-kotlin returns OK even though KSP failed.
38-
// if (
39-
// result.exitCode == KotlinCompilation.ExitCode.OK &&
40-
// "e: Error occurred in KSP, check log for detail" in result.messages
41-
// ) {
42-
// return JvmCompilationResult(KotlinCompilation.ExitCode.COMPILATION_ERROR, result.messages, this, )
43-
// }
44-
// return result
45-
}
46-
4734
private fun File.listSourceFiles(): Sequence<File> =
4835
walkTopDown().filter { it.isFile && (it.extension == "java" || it.extension == "kt") }
4936

5037
override val JvmCompilationResult.filesGeneratedByAnnotationProcessor: Sequence<File>
5138
get() = workingDir.resolve("ksp/sources").listSourceFiles()
5239

5340
class Factory(vararg processorProviders: () -> SymbolProcessorProvider) : Compilation.Factory {
54-
private val processorProviders = { processorProviders.map { it() }}
41+
private val processorProviders = { processorProviders.map { it() } }
5542

5643
override val expectedFilesDirectoryName: String
5744
get() = "ksp"

gradle/libs.versions.toml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
[versions]
2-
kotlin = "2.0.21"
2+
kotlin = "2.1.0"
33
dokka = "1.9.20"
4-
compileTesting = "0.6.0"
4+
compileTesting = "0.7.0"
55
autoService = "1.1.1"
66
incap = "1.0.0"
77
dagger = "2.52"
8-
ksp = "2.0.21-1.0.28"
8+
ksp = "2.1.0-1.0.29"
99
android-minSdk = "21"
1010
android-compileSdk = "35"
1111
androidx-test = "1.6.1"
@@ -28,7 +28,7 @@ kotlin-test = { module = "org.jetbrains.kotlin:kotlin-test", version.ref = "kotl
2828
kotlin-jvm-gradle = { module = "org.jetbrains.kotlin:kotlin-gradle-plugin", version.ref = "kotlin" }
2929
kotlin-compiler-embeddable = { module = "org.jetbrains.kotlin:kotlin-compiler-embeddable", version.ref = "kotlin" }
3030

31-
kotlinx-metadata = "org.jetbrains.kotlinx:kotlinx-metadata-jvm:0.9.0"
31+
kotlin-metadata = { module = "org.jetbrains.kotlin:kotlin-metadata-jvm", version.ref = "kotlin" }
3232

3333
dokka-gradlePlugin = { module = "org.jetbrains.dokka:dokka-gradle-plugin", version.ref = "dokka" }
3434
dokka-versioningPlugin = { module = "org.jetbrains.dokka:versioning-plugin", version.ref = "dokka" }

tests/build.gradle.kts

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import com.android.build.api.variant.HasTestFixturesBuilder
55
import com.android.build.api.variant.HasUnitTestBuilder
66
import com.android.build.gradle.internal.lint.AndroidLintAnalysisTask
77
import com.google.devtools.ksp.gradle.KspTask
8+
import org.jetbrains.kotlin.gradle.dsl.KotlinVersion
89

910
plugins {
1011
id("com.android.application")
@@ -32,6 +33,14 @@ android {
3233
}
3334
}
3435

36+
kotlin {
37+
compilerOptions {
38+
// Needed until Hilt supports Kotlin 2.1:
39+
// https://github.com/google/dagger/issues/4451
40+
languageVersion = KotlinVersion.KOTLIN_2_0
41+
}
42+
}
43+
3544
androidComponents {
3645
beforeVariants { variant ->
3746
(variant as? HasAndroidTestBuilder)?.androidTest?.enable = variant.buildType == "debug"
@@ -47,8 +56,8 @@ ksp {
4756
dependencies {
4857
implementation(libs.retrofit.moshi)
4958
implementation(libs.dagger.hilt.android)
50-
"kaptJava"(projects.compiler) { targetConfiguration = "shadow" }
51-
"kspKotlin"(projects.compiler) { targetConfiguration = "shadow" }
59+
"kaptJava"(projects.compiler)
60+
"kspKotlin"(projects.compiler)
5261
"kaptJava"(libs.dagger.compiler)
5362
"kspKotlin"(libs.dagger.compiler)
5463
"kaptJava"(libs.dagger.hilt.compiler)
@@ -70,8 +79,8 @@ dependencies {
7079

7180
// Unit test
7281
testImplementation(libs.dagger.hilt.android.testing)
73-
"kaptTestJava"(projects.compiler) { targetConfiguration = "shadow" }
74-
"kspTestKotlin"(projects.compiler) { targetConfiguration = "shadow" }
82+
"kaptTestJava"(projects.compiler)
83+
"kspTestKotlin"(projects.compiler)
7584
// Compile Only is used here to ensure it's included by the android module
7685
testCompileOnly(libs.androidx.startup)
7786
"kaptTestJava"(libs.dagger.compiler)

0 commit comments

Comments
 (0)