Minor cleanup release

Author: brianshumate

CHANGELOG.md

@@ -1,3 +1,8 @@
+## v1.8.3
+
+- Clean up task items for best practices
+- Update documentation
+
 ## v1.8.2
 
 - Nomad v0.9.0

README.md

@@ -17,7 +17,7 @@ in a development environment based on Vagrant and VirtualBox. See
 This role requires a Debian, RHEL, or Ubuntu distribution; the role is tested
 with the following specific software versions:
 
-* Ansible: 2.6.4
+* Ansible: 2.7.10
 * nomad: 0.9.0
 * CentOS: 7
 * Debian: 8

examples/README_VAGRANT.md

@@ -82,18 +82,18 @@ BOX_NAME="centos/7" vagrant up
 
 ## Notes
 
-0. This project functions with the following software versions:
-  * nomad version 0.8.4
-  * Ansible version 2.6.0
+1. This project functions with the following software versions:
+  * nomad version 0.9.0
+  * Ansible version 2.7.10
   * VirtualBox version 5.2.12
   * Vagrant version 2.1.2
   * Vagrant Hosts version 2.8.1
-1. This project uses Debian 8 (Jessie) by default, but you can choose other OS
+2. This project uses Debian 8 (Jessie) by default, but you can choose other OS
    with the *BOX_NAME* environment variable
-2. The `bin/preinstall` shell script performs the following actions for you:
+3. The `bin/preinstall` shell script performs the following actions for you:
  * Adds each node's host information to the host machine's `/etc/hosts`
  * Optionally installs the Vagrant hosts plugin
-3. If you see an error like *vm: The '' provisioner could not be found.*
+4. If you see an error like *vm: The '' provisioner could not be found.*
    make sure you have vagrant-hosts plugin installed
 
 ## References

tasks/install.yml

@@ -9,49 +9,66 @@
   tags: installation
 
 - name: Check Nomad package checksum file
-  local_action: stat path="{{ role_path }}/files/nomad_{{ nomad_version }}_SHA256SUMS"
+  stat:
+    path: "{{ role_path }}/files/nomad_{{ nomad_version }}_SHA256SUMS"
   become: false
   run_once: true
   tags: installation
   register: nomad_checksum
+  delegate_to: 127.0.0.1
 
 - name: Get Nomad package checksum file
-  local_action: get_url url="{{ nomad_checksum_file_url }}" dest="{{ role_path }}/files/nomad_{{ nomad_version }}_SHA256SUMS"
+  get_url:
+    url: "{{ nomad_checksum_file_url }}"
+    dest: "{{ role_path }}/files/nomad_{{ nomad_version }}_SHA256SUMS"
   become: false
   run_once: true
   tags: installation
-  when: nomad_checksum.stat.exists == False
+  when: not nomad_checksum.stat.exists
+  delegate_to: 127.0.0.1
 
 - name: Get Nomad package checksum
-  local_action: shell grep "{{ nomad_pkg }}" "{{ role_path }}/files/nomad_{{ nomad_version }}_SHA256SUMS"  | awk '{print $1}'
+  shell: grep "{{ nomad_pkg }}" "{{ role_path }}/files/nomad_{{ nomad_version }}_SHA256SUMS"  | awk '{print $1}'
   become: false
   register: nomad_sha256
   tags: installation
+  delegate_to: 127.0.0.1
 
 - name: Check Nomad package file
-  local_action: stat path="{{ role_path }}/files/{{ nomad_pkg }}"
+  stat:
+    path: "{{ role_path }}/files/{{ nomad_pkg }}"
   become: false
   register: nomad_package
+  delegate_to: 127.0.0.1
 
 - name: Download Nomad
-  local_action: get_url url="{{ nomad_zip_url }}" dest="{{ role_path }}/files/{{ nomad_pkg }}" checksum="sha256:{{ nomad_sha256.stdout }}" timeout="42"
+  get_url:
+    url: "{{ nomad_zip_url }}"
+    dest: "{{ role_path }}/files/{{ nomad_pkg }}"
+    checksum: "sha256:{{ nomad_sha256.stdout }}"
+    timeout: "42"
   become: false
   tags: installation
-  when: nomad_package.stat.exists == False
+  delegate_to: 127.0.0.1
+  when: not nomad_package.stat.exists
 
 - name: Create Temporary Directory for Extraction
-  local_action:
-    module: tempfile
+  tempfile:
     state: directory
     prefix: ansible-nomad.
   become: false
   register: install_temp
   tags: installation
+  delegate_to: 127.0.0.1
 
 - name: Unarchive Nomad
-  local_action: unarchive src="{{ role_path }}/files/{{ nomad_pkg }}" dest="{{ install_temp.path }}/" creates="{{ install_temp.path }}/nomad"
+  unarchive:
+    src: "{{ role_path }}/files/{{ nomad_pkg }}"
+    dest: "{{ install_temp.path }}/"
+    creates: "{{ install_temp.path }}/nomad"
   become: false
   tags: installation
+  delegate_to: 127.0.0.1
 
 - name: Install Nomad
   copy:
@@ -63,6 +80,9 @@
   tags: installation
 
 - name: Cleanup
-  local_action: file path="{{ install_temp.path }}" state="absent"
+  file:
+    path: "{{ install_temp.path }}"
+    state: "absent"
   become: false
   tags: installation
+  delegate_to: 127.0.0.1

tasks/main.yml

@@ -43,7 +43,7 @@
     dest: "{{ item }}"
     state: directory
     owner: "{{ nomad_user }}"
-    group: "{{ nomad_group}}"
+    group: "{{ nomad_group }}"
   with_items:
     - "{{ nomad_data_dir }}"
     - "{{ nomad_log_dir }}"
@@ -130,7 +130,8 @@
   when: ansible_service_mgr == "systemd"
 
 - name: reload systemd daemon
-  shell: systemctl daemon-reload
+  systemd:
+    daemon_reload: true
   when: ansible_service_mgr == "systemd"
 
 - name: Start Nomad

version.txt

@@ -1 +1 @@
-v1.8.2
+v1.8.3