Setup of the project with Django #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abha224 @Monal5031 @mayburgos Please review! 🎉 |
Monal5031
added
Category: Coding
abha224
reviewed
Jun 2, 2020
README.md
Outdated
| 1. Database Setup | ||
| <br> | ||
| Before starting with the project create a db in you local using PostgreSQL with the following details. Refer to `main/settings.py` if you have any confusion. | ||
| ``` |
There was a problem hiding this comment.
add a new line here, the below lines aren't formatted correctly.
abha224
reviewed
Jun 2, 2020
README.md
Outdated
|
|
||
| 1. Database Setup | ||
| <br> | ||
| Before starting with the project create a db in you local using PostgreSQL with the following details. Refer to `main/settings.py` if you have any confusion. |
There was a problem hiding this comment.
I suggest you add a few SQL commands( eg : createdb etc) for setting up PostgreSQL
Add requirements.txt as basic setup of the project Update .gitignore
|
@abha224 I have made the respective changes in the previous commit and squashed the new one with the old commit. Please review! 💯 |
abha224
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
README.mdwith basic setup and contributing instructionsrequirements.txtwith the necessary dependencies for the project.Fixes #5
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
The server is up and running and the mentioned URLs in
settings.pyare workingChecklist:
Code/Quality Assurance Only