Don't include weak requires in the summary, if there's already a strong require for the same symbol.

tsjs-language-eng · copybara-github · commit d5c292179895 · 2023-10-23T10:32:29.000-07:00
PiperOrigin-RevId: 575860298
diff --git a/src/summary.ts b/src/summary.ts
@@ -81,7 +81,12 @@ export class FileSummary {
   }
 
   get weakRequires(): Symbol[] {
-    return [...this.weakRequireSet.values()];
+    const weakRequires = [];
+    for (const [k, v] of this.weakRequireSet.entries()) {
+      if (this.strongRequireSet.has(k)) continue;
+      weakRequires.push(v);
+    }
+    return weakRequires;
   }
 
   addDynamicRequire(dynamicRequire: Symbol) {

Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,12 @@ export class FileSummary {`
`81`	`81`	`}`
`82`	`82`
`83`	`83`	`get weakRequires(): Symbol[] {`
`84`		`- return [...this.weakRequireSet.values()];`
	`84`	`+ const weakRequires = [];`
	`85`	`+ for (const [k, v] of this.weakRequireSet.entries()) {`
	`86`	`+ if (this.strongRequireSet.has(k)) continue;`
	`87`	`+ weakRequires.push(v);`
	`88`	`+ }`
	`89`	`+ return weakRequires;`
`85`	`90`	`}`
`86`	`91`
`87`	`92`	`addDynamicRequire(dynamicRequire: Symbol) {`