Skip to content

fix(datepicker): prevent matInput from clobbering date value #7831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 10, 2017
Merged

fix(datepicker): prevent matInput from clobbering date value #7831

merged 3 commits into from
Nov 10, 2017

Conversation

@mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Oct 16, 2017

fixes #7717

@mmalerba mmalerba requested review from crisbeto and jelbourn October 16, 2017 18:17
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 16, 2017
crisbeto
crisbeto approved these changes Oct 16, 2017
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit.

src/lib/input/input-value-accessor.ts
import {InjectionToken} from '@angular/core';


export const MAT_INPUT_VALUE_ACCESSOR =
Copy link
Member

@crisbeto crisbeto Oct 16, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a doc string describing what this is for?

rafaelss95
rafaelss95 reviewed Oct 16, 2017
View reviewed changes
src/lib/input/input-value-accessor.ts Outdated


export const MAT_INPUT_VALUE_ACCESSOR =
new InjectionToken<{value: any}>('MAT_INPIUT_VALUE_ACCESSOR');
Copy link
Contributor

@rafaelss95 rafaelss95 Oct 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo?

@mmalerba
Copy link
Contributor Author

mmalerba commented Oct 17, 2017

Done

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Oct 17, 2017
jelbourn
jelbourn approved these changes Oct 18, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba mentioned this pull request Oct 31, 2017
Closed
@kiancross
Copy link

kiancross commented Nov 5, 2017

Any ETA for when this will be merged?

@mmalerba mmalerba added the P2 The issue is important to a large percentage of users, with a workaround label Nov 7, 2017
@mmalerba mmalerba mentioned this pull request Nov 7, 2017
Closed
@josephperrott josephperrott merged commit 4b59ca1 into angular:master Nov 10, 2017
@mmalerba mmalerba mentioned this pull request Nov 14, 2017
Closed
@mmalerba mmalerba deleted the input-dp-value branch July 31, 2018 21:19
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 9, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

+1 more reviewer

@rafaelss95 rafaelss95 rafaelss95 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jelbourn jelbourn

@crisbeto crisbeto

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(Datepicker) Initial Value giving full datetime

7 participants

@mmalerba @kiancross @jelbourn @crisbeto @rafaelss95 @googlebot @josephperrott