fix: remove cdk re-exports from @angular/material #7112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelbourn
requested review from
andrewseguin,
crisbeto,
devversion,
josephperrott,
kara and
tinayuangao
as code owners
googlebot
added
the
cla: yes
jelbourn
added
the
P1
crisbeto
reviewed
Sep 15, 2017
| @@ -1,41 +0,0 @@ | |||
| import {Observable} from 'rxjs/Observable'; | |||
Member
There was a problem hiding this comment.
It seems like this removes the rx-chain tests completely.
Member
Author
There was a problem hiding this comment.
They were already copied to cdk earlier but not removed from lib
jelbourn
force-pushed
the
remove-cdk-reexports
branch
2 times, most recently
from
8fb1da4 to
2edb141
Compare
jelbourn
added
the
merge: caretaker note
Member
Author
|
Caretaker note: I have an internal change to go in before this one to prevent it from breaking anyone |
crisbeto
added
pr: lgtm
action: merge
Member
Author
|
Fixing unit tests, but that shouldn't block presumit |
jelbourn
force-pushed
the
remove-cdk-reexports
branch
from
2edb141 to
b910b0b
Compare
Member
Author
jelbourn
force-pushed
the
remove-cdk-reexports
branch
from
b910b0b to
13475fc
Compare
mmalerba
added
pr: needs rebase
and removed
action: merge
Contributor
|
needs rebase |
jelbourn
force-pushed
the
remove-cdk-reexports
branch
from
13475fc to
c2b0659
Compare
Member
Author
|
Rebased |
jelbourn
force-pushed
the
remove-cdk-reexports
branch
from
c2b0659 to
7b5de1b
Compare
BREAKING CHANGE: `@angular/material` no longer re-exports symbols from `@angular/cdk`.
jelbourn
force-pushed
the
remove-cdk-reexports
branch
from
7b5de1b to
c3ef774
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
@angular/materialno longer re-exports symbols from@angular/cdk.