Fix(slider): Add support for change event. #1618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Also clean up test slide event test code. Closes angular#1070
mmalerba
force-pushed
the
slider-change
branch
from
390cf07 to
fdf8477
Compare
jelbourn
reviewed
Nov 1, 2016
src/lib/slider/slider.spec.ts
Outdated
| * Note: The mouse event truncates the position for the click. | ||
| * @param element The element from which the event will be dispatched. | ||
| * @param trackElement The track element from which the event location will be calculated. | ||
| * @param containerElement The container element from which the event will be dispatched. |
There was a problem hiding this comment.
Instead of always passing in both the track element and the root slider element, why not just say the argument is sliderElement and querySelector for the trackElement?
|
LGTM |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also clean up test slide event test code. Closes #1070