fix(list): ensure multi-line lists expand to fill space #1466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kara
added
the
needs: discussion
googlebot
added
the
cla: yes
kara
changed the title
jelbourn
approved these changes
Oct 11, 2016
Member
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
LGTM aside from minor comments
| height: $three-line-height; | ||
| } | ||
|
|
||
| &.md-multi-line .md-list-item { |
Member
There was a problem hiding this comment.
Add comment explaining what the md-multi-line class means.
src/lib/list/list.spec.ts
Outdated
| ListWithItemWithCssClass, | ||
| ListWithDynamicNumberOfLines, | ||
| ListWithMultipleItems, | ||
| ListWithManyLines |
Contributor
Author
There was a problem hiding this comment.
ye with the trailing commas. done!
kara
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Material Design spec only recommends a maximum of three lines in list items, so this is what we formally support. However, if you decide to go off-spec and add more than three lines to a list item, all the lines are currently squeezed into a shorter height (which looks awful).
This PR allows list items with 4+ lines to expand to match the height of the contained text so they will look a bit saner.
r: @jelbourn
Closes #1391