feat(theming): add initial version for user-facing theming #1239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
kara
approved these changes
Sep 14, 2016
Contributor
kara
left a comment
kara
left a comment
There was a problem hiding this comment.
LGTM, just found a few typos
src/lib/button/_button-base.scss
Outdated
| &::after { | ||
| // The button spec calls for focus on raised buttons (and FABs) to be indicated with a | ||
| // black, 12% opacity shade over the normal color (for both light and dark themes). | ||
| // We do this by placing an :after psuedo-element with the appropriate shade over the button. |
src/lib/core/theming/_palette.scss
Outdated
| // | ||
| // Contrast colors are hard-coded because it is too difficult (probably impossible) to | ||
| // calculate them. These contrast colors are pulled from the public Material Design spec swatches. | ||
| // While the contrast colors in the spec are not perscriptive, we use them for convenience. |
Contributor
There was a problem hiding this comment.
Typo: perscriptive -> prescriptive
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @hansl @kara
#123
Apologies for not breaking up this PR into smaller pieces, the changes snowballed on me.
In this PR:
-theme.md-light-themeandmd-dark-themefunctions that outputs a "theme object", which is a sass map containing all of the theme's palettes.core.scssto_core.scss. The practical effect of this is that users either use one of the prebuilt theme css files OR, in defining their custom theme,@includethemd-core()mixin (once). With either approach, the user ends up only importing one css file for material in their app./** */to//. I made this change so that users who consume our mixins do not end up with a bunch of random comments in their css output._mixins.scssand move its contents to more specific files.md-visually-hiddenfrom a mixin to a single class and apply that class to use-sites.Coming in follow-up PRs: