Disambiguate between material and cdk docs

[jelbourn]

Goes along with angular/components#7675.

I've done some ugly things here- any suggestions on cleaning it up without hard-coding a bunch of repetitive stuff?

I'm also doing something weird with the router because I don't know the real way.

[amcdnl]

You could probably combine these loops into one w/ something like this:

for (const type in DOCS) {
  for (const cat of DOCS[type]) {
    for (let doc of cat.items) {
      doc.packageName = cat;
    }
  }
}

[jelbourn]

The packageName isn't the category; the categories are things like forms, layout, etc.

The type also isn't the package name, it's the section name ("components" and "cdk").

[jelbourn]

What I really want to do is generate this entire blob.

[willshowell]

This might be a nice time to use takeUntil so you don't have to manage all the subscriptions

private _onDestroy = new Subject<void>();

constructor() {
  this._router.events
    .takeUntil(this._onDestroy)
    .subscribe();
}

ngOnDestroy() {
  this._onDestroy.next();
  this._onDestroy.complete();
}

[jelbourn]

Done

[willshowell]

Maybe?

Observable.combineLatest(this._route.params.pluck('id'), this._route.parent.params.pluck('section'))
  .map(([id, section]) => docItems.getItemById(id, section))
  .takeUntil(this._onDestroy)
  .subscribe(docItem => ...);

[jelbourn]

Good suggestion; the typings for pluck are messy, so I did it manually from the tuple type

    Observable.combineLatest(_route.params, _route.parent.params)
        .map((p: [Params, Params]) => ({id: p[0]['id'], section: p[1]['section']}))
        .map(p => docItems.getItemById(p.id, p.section))
        .subscribe(d => {...});

[jelbourn]

I don't have a better idea for marking the package, so open for real review

[andrewseguin]

Needs rebase

[jelbourn]

@andrewseguin rebased

[andrewseguin]

LGTM