Skip to content

fix(list-key-manager): don't focus disabled items in typeahead mode #7382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2017
Merged

fix(list-key-manager): don't focus disabled items in typeahead mode #7382

merged 1 commit into from
Sep 29, 2017

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 28, 2017

Fixes the list key manager attempting to focus disabled items in typeahead mode.

@crisbeto
fix(list-key-manager): don't focus disabled items in typeahead mode
d57b6a0 
Fixes the list key manager attempting to focus disabled items in typeahead mode.
@crisbeto crisbeto added Accessibility This issue is related to accessibility (a11y) pr: needs review labels Sep 28, 2017
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 28, 2017
jelbourn
jelbourn approved these changes Sep 28, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Sep 28, 2017
@andrewseguin andrewseguin merged commit 1823b2f into angular:master Sep 29, 2017
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees

@jelbourn jelbourn

Labels

Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crisbeto @jelbourn @googlebot @andrewseguin