fix: set selected state for MdListOption in selectedOptions OnInit
#7189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
approved these changes
Sep 20, 2017
Member
devversion
left a comment
devversion
left a comment
There was a problem hiding this comment.
LGTM. A few minor comments
| super(); | ||
| } | ||
|
|
||
| ngOnInit() { |
Member
There was a problem hiding this comment.
Can you add the OnInit interface to the class?
src/lib/list/selection-list.spec.ts
Outdated
|
|
||
| @Component({template: ` | ||
| <mat-selection-list> | ||
| <md-list-option [selected]="true">Item</md-list-option> |
Member
There was a problem hiding this comment.
The template should have a two space indentation here (as in other test components)
src/lib/list/selection-list.spec.ts
Outdated
| imports: [MdListModule], | ||
| declarations: [ | ||
| SelectionListWithSelecedOption | ||
| ], |
Member
There was a problem hiding this comment.
Nit: This can fit into a single line.
josephperrott
force-pushed
the
select-initial
branch
from
17058cd to
b93d851
Compare
crisbeto
added
pr: lgtm
action: merge
rokikon
reviewed
Sep 21, 2017
| @Component({template: ` | ||
| <mat-selection-list> | ||
| <md-list-option [selected]="true">Item</md-list-option> | ||
| </mat-selection-list>`}) |
There was a problem hiding this comment.
You've got a typo here SelectionListWithSelecTedOption
josephperrott
force-pushed
the
select-initial
branch
from
b93d851 to
ce461e8
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7183