Skip to content

fix(select): extra whitespace around placeholder #6955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2017
Merged

fix(select): extra whitespace around placeholder #6955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/select/select.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
[class.mat-floating-placeholder]="_hasValue()"
[@transformPlaceholder]="_getPlaceholderAnimationState()"
[style.opacity]="_getPlaceholderOpacity()"
[style.width.px]="_selectedValueWidth"> {{ placeholder }} </span>
[style.width.px]="_selectedValueWidth">{{ placeholder }}</span>

<span class="mat-select-value" *ngIf="_hasValue()">
<span class="mat-select-value-text" [ngSwitch]="!!customTrigger">
Expand Down
2 changes: 1 addition & 1 deletion src/lib/select/select.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ $mat-select-trigger-underline-height: 1px !default;

// TODO: Double-check accessibility of this style
.mat-select-required &::after {
content: '*';
content: ' *';
Copy link
Contributor

@donroyco donroyco Sep 9, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's also a solution 😉 . Thanks @crisbeto

}
}

Expand Down