feat(dialog): allow disableClose option to be updated #4964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Jun 5, 2017
Member
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
Being able to update disableClose with this API is somewhat problematic because it means that some config properties can be updated live but other can't (e.g., position, size). This should be consistent one way or the other.
I would change the approach to add disableClose as a property to the dialog ref which is initially set from the config but can be subsequently updated.
crisbeto
force-pushed
the
3938/dialog-dynamic-disable-close
branch
from
42a11e9 to
6506b10
Compare
Member
Author
|
Addressed the feedback @jelbourn. |
crisbeto
force-pushed
the
3938/dialog-dynamic-disable-close
branch
from
6506b10 to
7e1bb72
Compare
crisbeto
added
action: merge
andrewseguin
added
pr: needs rebase
and removed
action: merge
Contributor
|
Needs rebase =) |
* Exposes the disableClose option via the `MdDialogRef` and allows for it to be updated. * Makes the `containerInstance` private to `MdDialogRef` since it doesn't make sense for it to be public anymore. * Completes the `backdropClick` observable once the associated `overlayRef` is destroyed. This avoids having to unsubscribe manually or having to use `Observable.first`. Fixes angular#3938.
crisbeto
force-pushed
the
3938/dialog-dynamic-disable-close
branch
from
7e1bb72 to
656c1fa
Compare
crisbeto
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MdDialogRefand allows for it to be updated.containerInstanceprivate toMdDialogRefsince it doesn't make sense for it to be public anymore.backdropClickobservable once the associatedoverlayRefis destroyed. This avoids having to unsubscribe manually or having to useObservable.first.Fixes #3938.