Skip to content

fix(tooltip): don't show tooltip if message is empty or not present #2081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2016
Merged

fix(tooltip): don't show tooltip if message is empty or not present #2081

merged 1 commit into from
Dec 6, 2016

Conversation

@belev
Copy link
Contributor

@belev belev commented Dec 5, 2016

Closes #2078

r: @jelbourn

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 5, 2016
@jelbourn
Copy link
Member

jelbourn commented Dec 5, 2016

R: @andrewseguin

andrewseguin
andrewseguin approved these changes Dec 5, 2016
View reviewed changes
Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin added action: merge The PR is ready for merge by the caretaker pr: lgtm and removed action: merge The PR is ready for merge by the caretaker labels Dec 5, 2016
@mmalerba mmalerba merged commit 2701aae into angular:master Dec 6, 2016
@belev belev deleted the dont-show-tooltip-if-message-not-present branch December 6, 2016 07:06
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 6, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees

@andrewseguin andrewseguin

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Empty tooltip should not be shown

5 participants

@belev @jelbourn @andrewseguin @googlebot @mmalerba