fix(ripple): Fix the ripple position #1820
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Nov 11, 2016
src/lib/core/ripple/ripple.ts
Outdated
| const isKeyEvent = | ||
| (event.screenX === 0 && event.screenY === 0 && event.pageX === 0 && event.pageY === 0); | ||
| this.end(event.pageX, event.pageY, isKeyEvent); | ||
| this.end(event.pageX, event.pageY - document.body.scrollTop, isKeyEvent); |
Member
There was a problem hiding this comment.
That page could be horizontally scrolled as well, so you should account for scrollLeft on the x-axis.
Does this still work if another element is scrolled other than body? Is there a unit test we can add for this? (connected position strategy has a lot of tests that deal with this type of thing).
Contributor
Author
There was a problem hiding this comment.
Fixed firefox & scrollLeft. Now it's working with elements other than body.
Working on unit test for this...
jelbourn
added
in progress
tinayuangao
force-pushed
the
ripple-fix
branch
from
b226a69 to
70efee5
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When scroll down the page, the ripple position is off
Closes #1817
R: @kara