Skip to content

chore: make it more obvious theming setup is required #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2016
Merged

chore: make it more obvious theming setup is required #1447

merged 1 commit into from
Oct 11, 2016

Conversation

@jelbourn
Copy link
Member

@jelbourn jelbourn commented Oct 6, 2016

R: @hansl

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 6, 2016
@jelbourn jelbourn mentioned this pull request Oct 11, 2016
Closed
kara
kara approved these changes Oct 11, 2016
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Oct 11, 2016
@kara kara merged commit fcc5900 into angular:master Oct 11, 2016
@kara kara mentioned this pull request Oct 11, 2016
Closed
2 tasks
@jelbourn jelbourn deleted the getting-started-themeing-clearer branch September 13, 2017 04:37
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@kara kara kara approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jelbourn @kara @googlebot