fix checkbox: add fixed width to checkbox #1103
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add fixed width to the checkbox so they do not squish if the parent wrapper has a fixed width and the label text is too long. closes #1097
googlebot
added
the
cla: yes
| vertical-align: middle; | ||
| white-space: nowrap; | ||
| width: $md-checkbox-size; | ||
| flex: 0 0 $md-checkbox-size; |
Member
There was a problem hiding this comment.
Why not just applying flex-shrink: 0?
Setting another flex basis should be unnecessary.
Author
There was a problem hiding this comment.
@devversion yeah, would also work this way. I can change it very quick if you want. Sorry for that!
Member
There was a problem hiding this comment.
Agreed- flex-shrink: 0 would be better.
Member
|
Closed in favor of #1713 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add fixed width to the checkbox so they do not squish if the parent
wrapper has a fixed width and the label text is too long.
closes #1097