File tree Expand file tree Collapse file tree 1 file changed +7
-6
lines changed Expand file tree Collapse file tree 1 file changed +7
-6
lines changed Original file line number Diff line number Diff line change @@ -360,12 +360,13 @@ export class MdSlider implements ControlValueAccessor {
360360 this . value = this . min ;
361361 break ;
362362 case LEFT_ARROW :
363- // It's kind of debatable what's the correct thing to do for inverted sliders. For a sighted
364- // user it would make more sense that when they press an arrow key the thumb moves in that
365- // direction. However for a blind user, nothing about the slider indicates that it is
366- // inverted. They will expect left to be decrement, regardless of how it appears on the
367- // screen. For speakers of RTL languages, they probably expect left to mean increment.
368- // Therefore we flip the meaning of the side arrow keys for RTL but not for inverted.
363+ // NOTE: For a sighted user it would make more sense that when they press an arrow key on an
364+ // inverted slider the thumb moves in that direction. However for a blind user, nothing
365+ // about the slider indicates that it is inverted. They will expect left to be decrement,
366+ // regardless of how it appears on the screen. For speakers ofRTL languages, they probably
367+ // expect left to mean increment. Therefore we flip the meaning of the side arrow keys for
368+ // RTL. For inverted sliders we prefer a good a11y experience to having it "look right" for
369+ // sighted users, therefore we do not swap the meaning.
369370 this . _increment ( this . direction == 'rtl' ? 1 : - 1 ) ;
370371 break ;
371372 case UP_ARROW :
You can’t perform that action at this time.
0 commit comments