Skip to content

Commit f10853a

Browse files
committed
address comments
1 parent d2e7fa0 commit f10853a

File tree

7 files changed

+15
-7
lines changed

7 files changed

+15
-7
lines changed

src/lib/chips/chips.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,5 +40,5 @@ use a neutral background color based on the current theme (light or dark). This
4040
`'primary'`, `'accent'`, or `'warn'`.
4141

4242
### Accessibility
43-
Chips has `role="option"` while chip list has `role="listbox"`. The chip input should have a
43+
Chips have role="option", while the chip list has `role="listbox"`. The chip input should have a
4444
placeholder or be given a meaningful label via `aria-label` or `aria-labelledby`.

src/lib/dialog/dialog.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,5 +128,8 @@ export class AppModule() {}
128128
```
129129

130130
### Accessibility
131-
The dialog has `role="dialog". The dialog will focus on the first tabbable element when opened,
131+
The dialog has `role="dialog", and dialog role can be overwritten to `alertdialog` in the
132+
appropriate context.
133+
134+
The dialog will focus on the first tabbable element when opened,
132135
and restore focus to the element that was focused before the dialog opened when closed.

src/lib/expansion/expansion.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,5 +103,5 @@ panel can be expanded at a given time:
103103
The expansion panel header has `role="button"`. The expansion panel header has attribute
104104
`aria-controls` with the expansion panel's id as value.
105105

106-
Users can use keyboard to activate the expansion panel header to switch between expanded state
106+
Users can use the keyboard to activate the expansion panel header to switch between expanded state
107107
and collapsed state.

src/lib/input/input.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,3 +153,10 @@ Here are the available global options:
153153

154154
### Accessibility
155155
The `mdInput` directive works with native `<input>` to provide an accessible experience.
156+
157+
If a placeholder attributed is added to the input, or a `md-placeholder` element is added
158+
in the form field, the placeholder text will automatically be used as the label for the input.
159+
If there's no placeholder specified, `aria-label`, `aria-labelledby` or `<label for=...>` should be
160+
added.
161+
162+
Any `md-error` and `md-hint` are automatically added to the input's `aria-describedby`.

src/lib/select/select.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,5 +98,3 @@ The select component without text or label should be given a meaningful label vi
9898
`aria-label` or `aria-labelledby`.
9999

100100
The select component has `role="listbox"` and options inside select has `role="option"`.
101-
Autocomplete trigger sets `aria-owns` to the autocomplete's id, and sets `aria-activedescendant` to
102-
the active option's id.

src/lib/sort/sort.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,4 +35,4 @@ by default it will use the id of the column.
3535
<!-- example(table-sorting) -->
3636

3737
### Accessibility
38-
The `aria-label` for sort button can be set in `MdSortHeaderIntl`.
38+
The `aria-label` for the sort button can be set in `MdSortHeaderIntl`.

src/lib/tabs/tabs.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,5 +81,5 @@ the `active` property to determine which tab is currently active. The correspond
8181
`<router-outlet>` can be placed anywhere in the view.
8282

8383
### Accessibility
84-
`MdTanNav`s without text or labels should be given a meaningful label via `aria-label` or
84+
`MdTabNav`s without text or labels should be given a meaningful label via `aria-label` or
8585
`aria-labelledby`.

0 commit comments

Comments
 (0)