Skip to content

Commit 8ebbd2f

Browse files
committed
Addressed comments
1 parent cbf2bcb commit 8ebbd2f

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

src/lib/radio/radio.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<div class="md-radio-container">
77
<div class="md-radio-outer-circle"></div>
88
<div class="md-radio-inner-circle"></div>
9-
<div md-ripple *ngIf="isRippleEnabled()" class="md-radio-ripple"
9+
<div md-ripple *ngIf="!disableRipple" class="md-radio-ripple"
1010
[md-ripple-trigger]="getHostElement()"
1111
[md-ripple-centered]="true"
1212
[md-ripple-speed-factor]="0.3"

src/lib/radio/radio.spec.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -221,14 +221,16 @@ describe('MdRadio', () => {
221221
fixture.detectChanges();
222222
for (let radioNativeElement of radioNativeElements)
223223
{
224-
expect(radioNativeElement.querySelectorAll('[md-ripple]').length).toBe(1);
224+
expect(radioNativeElement.querySelectorAll('[md-ripple]').length)
225+
.toBe(1, 'Expect [md-ripple] in radio buttons');
225226
}
226227

227228
testComponent.disableRipple = true;
228229
fixture.detectChanges();
229230
for (let radioNativeElement of radioNativeElements)
230231
{
231-
expect(radioNativeElement.querySelectorAll('[md-ripple]').length).toBe(0);
232+
expect(radioNativeElement.querySelectorAll('[md-ripple]').length)
233+
.toBe(0, 'Expect no [md-ripple] in radio buttons');
232234
}
233235
}));
234236
});

src/lib/radio/radio.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -421,10 +421,6 @@ export class MdRadioButton implements OnInit {
421421
getHostElement() {
422422
return this._elementRef.nativeElement;
423423
}
424-
425-
isRippleEnabled() {
426-
return !this.disableRipple;
427-
}
428424
}
429425

430426

0 commit comments

Comments
 (0)